You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/04/20 08:35:46 UTC
[kudu-CR] [unit test] Fix a semantics problem
Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18429
Change subject: [unit test] Fix a semantics problem
......................................................................
[unit test] Fix a semantics problem
When I do some tests (the work is doing), I found AllowRecovery()
maybe should fix.
According to semantics, I think AllowRecovery() should enable all
tservers recovery.
Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
---
M src/kudu/integration-tests/disk_failure-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/18429/1
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
[kudu-CR] [disk failure-itest] fix premature return from AllowRecovery()
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18429 )
Change subject: [disk_failure-itest] fix premature return from AllowRecovery()
......................................................................
Patch Set 2:
(2 comments)
ok, Done
http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG@7
PS1, Line 7: [disk_failure-itest] fix premature
> nit: how about
Done
http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG@9
PS1, Line 9: Fixed a premature return from the AllowRecovery() utility function.
: Prior to this fix, the error injection flags
: were reset only for the first tserver upon call
: to AllowRecovery().
:
> nit: how about
Done
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 06:30:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [disk failure-itest] fix premature return from AllowRecovery()
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18429 )
Change subject: [disk_failure-itest] fix premature return from AllowRecovery()
......................................................................
[disk_failure-itest] fix premature return from AllowRecovery()
Fixed a premature return from the AllowRecovery() utility function.
Prior to this fix, the error injection flags
were reset only for the first tserver upon call
to AllowRecovery().
Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Reviewed-on: http://gerrit.cloudera.org:8080/18429
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/integration-tests/disk_failure-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yifan Zhang: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [disk failure-itest] fix premature return from AllowRecovery()
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18429 )
Change subject: [disk_failure-itest] fix premature return from AllowRecovery()
......................................................................
Patch Set 2: Verified+1 Code-Review+2
Unrelated test failures:
ToolTest.TestRebuildTserverByLocalReplicaCopy
TServerQuiescingITest.TestQuiescingToolBasics
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 09:09:17 +0000
Gerrit-HasComments: No
[kudu-CR] [disk failure-itest] fix premature return from AllowRecovery()
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has removed a vote on this change.
Change subject: [disk_failure-itest] fix premature return from AllowRecovery()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR] [disk failure-itest] fix premature return from AllowRecovery()
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18429
to look at the new patch set (#2).
Change subject: [disk_failure-itest] fix premature return from AllowRecovery()
......................................................................
[disk_failure-itest] fix premature return from AllowRecovery()
Fixed a premature return from the AllowRecovery() utility function.
Prior to this fix, the error injection flags
were reset only for the first tserver upon call
to AllowRecovery().
Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
---
M src/kudu/integration-tests/disk_failure-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/18429/2
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [unit test] Fix a semantics problem
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18429 )
Change subject: [unit test] Fix a semantics problem
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Looks good!
Consider updating the commit message to make it a bit more concise.
http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG@7
PS1, Line 7: [unit test] Fix a semantics problem
nit: how about
[disk_failure-itest] fix premature return from AllowRecovery()
http://gerrit.cloudera.org:8080/#/c/18429/1//COMMIT_MSG@9
PS1, Line 9: When I do some tests (the work is doing), I found AllowRecovery()
: maybe should fix.
:
: According to semantics, I think AllowRecovery() should enable all
: tservers recovery.
nit: how about
Fixed a premature return from the AllowRecovery() utility function. Prior to this fix, the error injection flags
were reset only for the first table server upon call
to AllowRecovery().
--
To view, visit http://gerrit.cloudera.org:8080/18429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8759d45623e33c5b2b21fceb681f277ab4e1c113
Gerrit-Change-Number: 18429
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Apr 2022 00:36:07 +0000
Gerrit-HasComments: Yes