You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/04/23 11:29:08 UTC

Review Request 58651: Extend operator documentation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

Included changes:

* new cluster upgrade instructions
* docs for several best practices collected on the mailinglist
* extracted and extended troubleshooting guide for new cluster operators
* several minor formatting fixes


Diffs
-----

  docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
  docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
  docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
  docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
  docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
  docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
  docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
  docs/operations/troubleshooting.md PRE-CREATION 
  docs/operations/upgrades.md PRE-CREATION 
  docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 


Diff: https://reviews.apache.org/r/58651/diff/1/


Testing
-------

Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs


Thanks,

Stephan Erb

Re: Review Request 58651: Extend operator documentation

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/#review172749
-----------------------------------------------------------


Ship it!




Master (2026ca0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 23, 2017, 11:29 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58651/
> -----------------------------------------------------------
> 
> (Updated April 23, 2017, 11:29 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Included changes:
> 
> * new cluster upgrade instructions
> * docs for several best practices collected on the mailinglist
> * extracted and extended troubleshooting guide for new cluster operators
> * several minor formatting fixes
> 
> 
> Diffs
> -----
> 
>   docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
>   docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
>   docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
>   docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
>   docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
>   docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
>   docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
>   docs/operations/troubleshooting.md PRE-CREATION 
>   docs/operations/upgrades.md PRE-CREATION 
>   docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 
> 
> 
> Diff: https://reviews.apache.org/r/58651/diff/1/
> 
> 
> Testing
> -------
> 
> Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 58651: Extend operator documentation

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/#review172849
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On April 23, 2017, 4:29 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58651/
> -----------------------------------------------------------
> 
> (Updated April 23, 2017, 4:29 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Included changes:
> 
> * new cluster upgrade instructions
> * docs for several best practices collected on the mailinglist
> * extracted and extended troubleshooting guide for new cluster operators
> * several minor formatting fixes
> 
> 
> Diffs
> -----
> 
>   docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
>   docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
>   docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
>   docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
>   docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
>   docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
>   docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
>   docs/operations/troubleshooting.md PRE-CREATION 
>   docs/operations/upgrades.md PRE-CREATION 
>   docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 
> 
> 
> Diff: https://reviews.apache.org/r/58651/diff/1/
> 
> 
> Testing
> -------
> 
> Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 58651: Extend operator documentation

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/
-----------------------------------------------------------

(Updated April 25, 2017, 11:25 p.m.)


Review request for Aurora.


Changes
-------

Review changes.


Repository: aurora


Description
-------

Included changes:

* new cluster upgrade instructions
* docs for several best practices collected on the mailinglist
* extracted and extended troubleshooting guide for new cluster operators
* several minor formatting fixes


Diffs (updated)
-----

  docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
  docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
  docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
  docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
  docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
  docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
  docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
  docs/operations/troubleshooting.md PRE-CREATION 
  docs/operations/upgrades.md PRE-CREATION 
  docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 


Diff: https://reviews.apache.org/r/58651/diff/2/

Changes: https://reviews.apache.org/r/58651/diff/1-2/


Testing
-------

Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs


Thanks,

Stephan Erb

Re: Review Request 58651: Extend operator documentation

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/#review172800
-----------------------------------------------------------


Ship it!




Ship It!

- David McLaughlin


On April 23, 2017, 11:29 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58651/
> -----------------------------------------------------------
> 
> (Updated April 23, 2017, 11:29 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Included changes:
> 
> * new cluster upgrade instructions
> * docs for several best practices collected on the mailinglist
> * extracted and extended troubleshooting guide for new cluster operators
> * several minor formatting fixes
> 
> 
> Diffs
> -----
> 
>   docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
>   docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
>   docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
>   docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
>   docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
>   docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
>   docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
>   docs/operations/troubleshooting.md PRE-CREATION 
>   docs/operations/upgrades.md PRE-CREATION 
>   docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 
> 
> 
> Diff: https://reviews.apache.org/r/58651/diff/1/
> 
> 
> Testing
> -------
> 
> Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 58651: Extend operator documentation

Posted by Stephan Erb <se...@apache.org>.

> On April 24, 2017, 8:25 p.m., Joshua Cohen wrote:
> > docs/operations/installation.md
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/58651/diff/1/?file=1697874#file1697874line29>
> >
> >     Maybe s/dedicated/separate?
> >     
> >     The way it's worded now makes it seem like you want to dedicate a single ensemble to both election and service discovery. This is obviously not the case based on the following sentence, but it's not entirely clear.

Good catch. Thanks.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/#review172831
-----------------------------------------------------------


On April 25, 2017, 11:25 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58651/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 11:25 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Included changes:
> 
> * new cluster upgrade instructions
> * docs for several best practices collected on the mailinglist
> * extracted and extended troubleshooting guide for new cluster operators
> * several minor formatting fixes
> 
> 
> Diffs
> -----
> 
>   docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
>   docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
>   docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
>   docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
>   docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
>   docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
>   docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
>   docs/operations/troubleshooting.md PRE-CREATION 
>   docs/operations/upgrades.md PRE-CREATION 
>   docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 
> 
> 
> Diff: https://reviews.apache.org/r/58651/diff/2/
> 
> 
> Testing
> -------
> 
> Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 58651: Extend operator documentation

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58651/#review172831
-----------------------------------------------------------


Ship it!





docs/operations/installation.md
Lines 29 (patched)
<https://reviews.apache.org/r/58651/#comment245863>

    Maybe s/dedicated/separate?
    
    The way it's worded now makes it seem like you want to dedicate a single ensemble to both election and service discovery. This is obviously not the case based on the following sentence, but it's not entirely clear.


- Joshua Cohen


On April 23, 2017, 11:29 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58651/
> -----------------------------------------------------------
> 
> (Updated April 23, 2017, 11:29 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Included changes:
> 
> * new cluster upgrade instructions
> * docs for several best practices collected on the mailinglist
> * extracted and extended troubleshooting guide for new cluster operators
> * several minor formatting fixes
> 
> 
> Diffs
> -----
> 
>   docs/README.md dfd3a23c3341922a8d13303453086cf8f1774609 
>   docs/features/custom-executors.md 40fc118a864b4731998bafa4777399252695f4e2 
>   docs/features/webhooks.md 075aeec4159d486e4ea78ffdda96b3b12ece9212 
>   docs/operations/backup-restore.md da467c3c2bccacd5f3923d190b4786e9e397b876 
>   docs/operations/configuration.md 203f3be767347e7759f33e3e15bca50c9a37a9c5 
>   docs/operations/installation.md f9b04d4ebe920e846c6b71c223c9f5d77dc7a3cf 
>   docs/operations/storage.md c30922fef7075308802dabdd1d84a983ca508428 
>   docs/operations/troubleshooting.md PRE-CREATION 
>   docs/operations/upgrades.md PRE-CREATION 
>   docs/reference/scheduler-endpoints.md d302e9001bbd441a3c303a9e445bee57dc969ac7 
> 
> 
> Diff: https://reviews.apache.org/r/58651/diff/1/
> 
> 
> Testing
> -------
> 
> Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>