You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:18:59 UTC
Re: Review Request 50456: Added custom command to generate Java
protobufs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/
-----------------------------------------------------------
(Updated Dec. 10, 2016, 7:18 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5902
https://issues.apache.org/jira/browse/MESOS-5902
Repository: mesos
Description (updated)
-------
The Patch creates required directories mentioned below
${MESOS_BIN_INCLUDE_DIR}/java
${MESOS_BIN_SRC_DIR}/java/generated
Creates Java protobuf definitions under
${MESOS_BIN_SRC_DIR}/java/generated.
Diffs (updated)
-----
cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc
src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc
src/java/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/50456/diff/
Testing
-------
cmake .. && make mesos-java-protos.
check to see if java/generated folder has all the new java files created.
<BUILD_DIR>/src/java/generated/org/apache/mesos/containerizer/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/fetcher/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/scheduler/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/v1/executor/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/v1/Protos.java
<BUILD_DIR>/src/java/generated/org/apache/mesos/v1/scheduler/Protos.java
Thanks,
Srinivas Brahmaroutu
Re: Review Request 50456: Added custom command to generate Java
protobufs.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50456/#review167509
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 10, 2016, 7:18 p.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50456/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2016, 7:18 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5902
> https://issues.apache.org/jira/browse/MESOS-5902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Patch creates required directories mentioned below
> ${MESOS_BIN_INCLUDE_DIR}/java
> ${MESOS_BIN_SRC_DIR}/java/generated
>
> Creates Java protobuf definitions under
> ${MESOS_BIN_SRC_DIR}/java/generated.
>
>
> Diffs
> -----
>
> cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc
> src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc
> src/java/CMakeLists.txt PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/50456/diff/5/
>
>
> Testing
> -------
>
> cmake .. && make mesos-java-protos.
> check to see if java/generated folder has all the new java files created.
> <BUILD_DIR>/src/java/generated/org/apache/mesos/containerizer/Protos.java
> <BUILD_DIR>/src/java/generated/org/apache/mesos/fetcher/Protos.java
> <BUILD_DIR>/src/java/generated/org/apache/mesos/Protos.java
> <BUILD_DIR>/src/java/generated/org/apache/mesos/scheduler/Protos.java
> <BUILD_DIR>/src/java/generated/org/apache/mesos/v1/executor/Protos.java
> <BUILD_DIR>/src/java/generated/org/apache/mesos/v1/Protos.java
> <BUILD_DIR>/src/java/generated/org/apache/mesos/v1/scheduler/Protos.java
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>