You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by clems4ever <gi...@git.apache.org> on 2018/04/14 09:56:01 UTC
[GitHub] mesos pull request #281: Add alg RS256 support for JWT generator and validat...
GitHub user clems4ever opened a pull request:
https://github.com/apache/mesos/pull/281
Add alg RS256 support for JWT generator and validator.
Currently, the JWT library only support creating and validating HS256 tokens. I implemented the creation and validation of RS256 tokens.
The interface is accepting a shared pointer of RSA as input for RSA keys to be as generic as possible but I also provide helper functions to convert PEM representation of keys into RSA keys so that it is easy to read the PEM on disk. I will probably implement the JWK representation of keys in a coming review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clems4ever/mesos jwt-rs256
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mesos/pull/281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #281
----
commit bd940a0ef88b265daac707916e34cd43f1f8e7d6
Author: Clement Michaud <cl...@...>
Date: 2018-04-14T09:02:17Z
Add alg RS256 support for JWT generator and validator.
----
---
[GitHub] mesos pull request #281: Add alg RS256 support for JWT generator and validat...
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever closed the pull request at:
https://github.com/apache/mesos/pull/281
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by tillt <gi...@git.apache.org>.
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever can we have tests as well? :)
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by tillt <gi...@git.apache.org>.
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever this looks really good - let's get it into a committable state. I have added you to Apache Mesos as a contributor and assigned me as a shepherd to your improvement.
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
Hello @tillt , thank you for having a look. Don't you need to merge the following PR to make me a contributor: https://github.com/apache/mesos/pull/282/commits?
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tillt , no pb, I will create a review in the review board now. Thanks.
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
Closing this PR since reviews are in the review board.
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tilt, what do you mean? There are tests in the commit already.
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by tillt <gi...@git.apache.org>.
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever and missed that as well :D - it was hidden due to its size (large diff).
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by tillt <gi...@git.apache.org>.
Github user tillt commented on the issue:
https://github.com/apache/mesos/pull/281
@clems4ever I totally missed your second PR - sorry for that. Merged it now.
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tilt, here you go: https://reviews.apache.org/r/66621/.
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
@tilt, yes, large diff because I refactored a bit and added as many tests as there are for HS256. :)
---
[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.
Posted by clems4ever <gi...@git.apache.org>.
Github user clems4ever commented on the issue:
https://github.com/apache/mesos/pull/281
Since this change is not really trivial, I will go through the contributing process. I'm currently creating my accounts.
---