You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/19 03:11:50 UTC
[GitHub] [pulsar] aloyszhang opened a new pull request #7848: take seek time into account in Reader#hasMessageAvailable
aloyszhang opened a new pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848
Fixes #7796
### Motivation
This PR takes seek time into account in Reader#hasMessageAvailable.
### Modifications
1. mark the timestamp in `Reader` whenever `seek(timestamp)`
2. compare the marked timestamp with the publish time of last messag to decide `Reader#hasMessageAvailable` give true or false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678372059
lexicographical
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-676566684
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675890018
@sijie @jiazhai CI failed when build pulsar image all the time, error information
```shell
[ERROR] The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:24 min
[INFO] Finished at: 2020-08-19T06:51:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-docker-image: Could not build image: The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
##[error]Process completed with exit code 1.
```
It seems have nothing to do with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
BewareMyPower edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739325082
@codelipenghui Since this PR changes the seek response from `CommandSuccess` to `CommandSeekResponse`, the other clients may fail with `seek`. Is it proper to include this PR in 2.7.1? Because the other clients may work well with 2.7.0 but fail with 2.7.1. I'm just curious about the compatibility among x.y.0 and x.y.z.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-684757156
@codelipenghui Does this pr need more discuss?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-686567799
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-714998477
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675838846
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-681847373
@aloyszhang
> Thanks for your reply. I think use message id is a alternative way.
But I don't think clock time is an issue, since both the publish time and seek time are specified from the client side.
Using publish time and seek time to decides whether have available messages make sence for me.
the publish time and the seek time may be assigned by the different client, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678260804
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739931076
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-748400832
> @codelipenghui Since this PR changes the seek response from `CommandSuccess` to `CommandSeekResponse`, the other clients may fail with `seek`. Is it proper to include this PR in 2.7.1? Because the other clients may work well with 2.7.0 but fail with 2.7.1. I'm just curious about the compatibility among x.y.0 and x.y.z.
This would be an issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-688640516
cc @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678264848
@codelipenghui Thanks ,I will try it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-676566684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678970287
@codelipenghui @jiazhai CI failed all the time, PATL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-732690261
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-677749218
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675890018
@sijie @jiazhai CI failed when build pulsar image all the time, error information
```shell
[ERROR] The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:24 min
[INFO] Finished at: 2020-08-19T06:51:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-docker-image: Could not build image: The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
##[error]Process completed with exit code 1.
```
It seems have nothing to do with this PR. Any suggestions for resolve this CI problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-716533499
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-687196590
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-687027934
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678887893
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-714901261
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-676182220
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678562989
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678341422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on a change in pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on a change in pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#discussion_r537179193
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1907,11 +1907,16 @@ public void seek(long timestamp) throws PulsarClientException {
log.info("[{}][{}] Seek subscription to publish time {}", topic, subscription, timestamp);
- cnx.sendRequestWithId(seek, requestId).thenRun(() -> {
+ cnx.sendSeekRequestWithId(seek, requestId).thenAccept((seekResponse) -> {
log.info("[{}][{}] Successfully reset subscription to publish time {}", topic, subscription, timestamp);
acknowledgmentsGroupingTracker.flushAndClean();
- seekMessageId = new BatchMessageIdImpl((MessageIdImpl) MessageId.earliest);
+ MessageIdData messageIdData = seekResponse.getMessageIdData();
+ seekMessageId = new BatchMessageIdImpl(messageIdData.getLedgerId(), messageIdData.getEntryId(),
+ messageIdData.getPartition(), -1);
Review comment:
Batch index set to -1 since currently broker find message by timestamp at entry level.
I think we can add a new issue if we want to support it at messag level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-689526308
@aloyszhang Thanks for the contribution. I agree with Penghui, we should make ledgerId/entryId as the source of truth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-688578693
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678887893
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-687236112
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678862461
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678397924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739865518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-692491022
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-843791153
ping @315157973 Could you please help take a look at this issue? Seems related to https://github.com/apache/pulsar/pull/10414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678932673
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675890018
@sijie @jiazhai CI failed when build pulsar image , error information
```shell
[ERROR] The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:24 min
[INFO] Finished at: 2020-08-19T06:51:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-docker-image: Could not build image: The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
##[error]Process completed with exit code 1.
```
It seems have nothing to do with this PR. Any suggestions for resolving this CI problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-783139335
Remove the `release/2.7.1` tag because of changing the proto file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675873392
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-695797852
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-692491022
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-688391897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-681882284
@codelipenghui
> the publish time and the seek time may be assigned by the different client, right?
Yes, the publish time and the seek time can be assigned by different client. But in my opoion, maybe `Clock synchronization` issue can be ignored. Since, if we consider `Clock synchronization` among all client, the `Reader#seek` also has problem if client seek message published by other client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-716959977
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-703601433
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-686567799
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-740345603
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-687027934
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678341422
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675854276
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678381923
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675838846
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678329438
@codelipenghui
Thanks for your reply. I think use `message id` is a alternative way.
But I don't think clock time is an issue, since both the `publish time` and `seek time` are specified from the client side.
Using `publish time` and `seek time` to decides whether have available messages make sence for me.
Think about this case,
if we seek at a timestamp after `publish time` of the last message, there **should be no messages available**.
But if we use MessageId to decides whether have available messages ,
1. the `seek(Timestamp)` will return with the `last messageId`
2. the `getLastMessageId` also return the `last messageId`
3. if `resetIncludeHead` is true
`hasMessageAvailable` will return true, and this is not right. So in this case, we should do more border control to keep it works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-1058899455
@aloyszhang:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#discussion_r536790765
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1907,11 +1907,16 @@ public void seek(long timestamp) throws PulsarClientException {
log.info("[{}][{}] Seek subscription to publish time {}", topic, subscription, timestamp);
- cnx.sendRequestWithId(seek, requestId).thenRun(() -> {
+ cnx.sendSeekRequestWithId(seek, requestId).thenAccept((seekResponse) -> {
log.info("[{}][{}] Successfully reset subscription to publish time {}", topic, subscription, timestamp);
acknowledgmentsGroupingTracker.flushAndClean();
- seekMessageId = new BatchMessageIdImpl((MessageIdImpl) MessageId.earliest);
+ MessageIdData messageIdData = seekResponse.getMessageIdData();
+ seekMessageId = new BatchMessageIdImpl(messageIdData.getLedgerId(), messageIdData.getEntryId(),
+ messageIdData.getPartition(), -1);
Review comment:
Why set the batch index to -1? And in `seekAsync(MessageId messageId)`, `seekMessageId` was set the `messageId` but not what the seek response contains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on a change in pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on a change in pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#discussion_r537179193
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1907,11 +1907,16 @@ public void seek(long timestamp) throws PulsarClientException {
log.info("[{}][{}] Seek subscription to publish time {}", topic, subscription, timestamp);
- cnx.sendRequestWithId(seek, requestId).thenRun(() -> {
+ cnx.sendSeekRequestWithId(seek, requestId).thenAccept((seekResponse) -> {
log.info("[{}][{}] Successfully reset subscription to publish time {}", topic, subscription, timestamp);
acknowledgmentsGroupingTracker.flushAndClean();
- seekMessageId = new BatchMessageIdImpl((MessageIdImpl) MessageId.earliest);
+ MessageIdData messageIdData = seekResponse.getMessageIdData();
+ seekMessageId = new BatchMessageIdImpl(messageIdData.getLedgerId(), messageIdData.getEntryId(),
+ messageIdData.getPartition(), -1);
Review comment:
Batch index set to -1 since currently broker find message by timestamp at entry level.
I think we can raise up a new issue if we want to support it at messag level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739324457
The cpp tests will be passed after merging [my PR](https://github.com/aloyszhang/pulsar/pull/1).
However, when I tried to add a unit test for `testHasMessageAvailableAfterSeekTime`, it failed. After looking into the issue, it's because there're some problems with C++ reader's hasMessageAvailable` implementation. Instead of involving these changes including related tests into this PR, I think it's better to open a new PR to fix it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-694600283
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-683504129
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678372059
lexicographical
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678410174
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-703601433
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-687196590
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-708882768
@aloyszhang Is the change ready for review again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-740275066
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-714998477
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-688391897
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678606100
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675890018
@sijie @jiazhai CI failed when build pulsar image all the time, error information
```shell
[ERROR] The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:24 min
[INFO] Finished at: 2020-08-19T06:51:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-docker-image: Could not build image: The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
##[error]Process completed with exit code 1.
```
It seems have nothing to do with this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-683504129
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-721698650
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-714901261
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678397924
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-740408837
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-732932688
@BewareMyPower Thanks for your help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a change in pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on a change in pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#discussion_r649802437
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/util/MessageIdUtils.java
##########
@@ -41,4 +44,11 @@ public static final MessageId getMessageId(long offset) {
return new MessageIdImpl(ledgerId, entryId, -1);
}
+
+ public static int getBathIndexFromMessageIdData(PulsarApi.MessageIdData messageIdData) {
Review comment:
should be getBatchIndexFromMessageIdData
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678562989
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-715921299
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-694600283
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-742477792
ping @sijie @codelipenghui @jiazhai Would you please take a look about this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-709679525
@sijie I'll check whether failed CI has relation to this PR or not soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-676182220
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675854276
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-740409743
@codelipenghui PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-732538994
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678329438
@codelipenghui
Thanks for your reply. I think use `message id` is a alternative way.
But I don't think clock time is an issue, since both the `publish time` and `seek time` are specified from the client side.
Using `publish time` and `seek time` to decides whether have available messages make sence for me.
Think about this case,
if we seek at a timestamp after `publish time` of the last message, there **should be no messages available**.
But if we use MessageId to decides whether have available messages ,
1. the `seek(Timestamp)` will return with the `last messageId`
2. the `getLastMessageId` also return the `last messageId`
3. if `resetIncludeHead` is true
`hasMessageAvailable` will return true, and this is not right. So in this case, we should do more border control to keep it works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675873392
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678329438
@codelipenghui
Thanks for your reply. I think use `message id` is a alternative way.
But I don't think clock time is an issue, since both the `publish time` and `seek time` are specified from the client side.
Using `publish time` and `seek time` to decides whether have available messages make sence for me.
Think about this case,
if we seek at a timestamp after `publish time` of the last message, there **should be no messages available**.
But if we use MessageId to decides whether have available messages ,
1. the `seek(Timestamp)` will return with the `last messageId`
2. the `getLastMessageId` also return the `last messageId`
3. if `resetIncludeHead` is true
`hasMessageAvailable` will return true, and this is not right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang edited a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang edited a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-675890018
@sijie @jiazhai CI failed when build pulsar image all the time, error information
```shell
[ERROR] The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:24 min
[INFO] Finished at: 2020-08-19T06:51:53Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.4.13:build (default) on project pulsar-docker-image: Could not build image: The command '/bin/sh -c /pulsar/bin/install-pulsar-client-27.sh' returned a non-zero code: 1 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
##[error]Process completed with exit code 1.
```
It seems have nothing to do with this PR. Any suggestions for resolving this CI problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-716533499
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-728642649
move to 2.8.0 first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678862461
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-687236112
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739325082
@codelipenghui Since this PR changes the seek response from `CommandSuccess` to ``CommandSeekResponse`, the other clients may fail with `seek`. Is it proper to include this PR in 2.7.1? Because the other clients may work well with 2.7.0 but fail with 2.7.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-732730942
For the test error caused by change of `CommandSeekResponse`, I'll take a look at C++ client later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-695797852
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-740409743
@codelipenghui "CI - Unit - Brokers - Broker Group 1 /" always cancled,
```bash
[INFO] Running org.apache.pulsar.broker.namespace.OwnerShipForCurrentServerTestBase$2
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.039 s - in org.apache.pulsar.broker.namespace.OwnerShipForCurrentServerTestBase$2
[INFO] Running org.apache.pulsar.broker.namespace.NamespaceUnloadingTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.319 s - in org.apache.pulsar.broker.namespace.NamespaceUnloadingTest
[INFO] Running org.apache.pulsar.broker.namespace.NamespaceServiceTest$1
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.55 s - in org.apache.pulsar.broker.SLAMonitoringTest
[INFO] Running org.apache.pulsar.broker.namespace.NamespaceOwnershipListenerTests
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.043 s - in org.apache.pulsar.broker.namespace.NamespaceServiceTest$1
[INFO] Running org.apache.pulsar.broker.namespace.OwnerShipForCurrentServerTestBase$1
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.042 s - in org.apache.pulsar.broker.namespace.OwnerShipForCurrentServerTestBase$1
[INFO] Running org.apache.pulsar.broker.ConfigHelper
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 s - in org.apache.pulsar.broker.ConfigHelper
[INFO] Running org.apache.pulsar.broker.lookup.http.HttpTopicLookupv2Test
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.434 s - in org.apache.pulsar.broker.lookup.http.HttpTopicLookupv2Test
[INFO] Running org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.279 s - in org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.869 s - in org.apache.pulsar.broker.namespace.NamespaceOwnershipListenerTests
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.447 s - in org.apache.pulsar.broker.namespace.NamespaceServiceTest
Error: The operation was canceled.
```
Could you please help to take a look about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-732538994
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-688599787
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-843817956
> ping @315157973 Could you please help take a look at this issue? Seems related to #10414
This problem has always been there, and it is not caused by my PR. This PR also fixes the problem of the reader, all hasMessageAvailable returns true, but the message cannot be read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-739865518
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-678263849
@aloyszhang You can try to rebase the apache master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #7848:
URL: https://github.com/apache/pulsar/pull/7848#issuecomment-715921299
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org