[GitHub] guacamole-client pull request #311: GUACAMOLE-611: Selectively fall through ...

[mike-jumper <gi...@git.apache.org>]

Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/311#discussion_r215516620
  
    --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/AuthenticationProviderFacade.java ---
    @@ -48,6 +48,16 @@
          */
         private final AuthenticationProvider authProvider;
     
    +    /**
    +     * The set of identifiers of all authentication providers whose internal
    +     * failures should be tolerated during the authentication process. If the
    +     * identifier of this authentication provider is within this set, errors
    +     * during authentication will result in the authentication provider being
    +     * ignored for that authentication attempt. By default, errors during
    +     * authentication halt the authentication process entirely.
    +     */
    +    private final Set<String> tolerateFailures;
    --- End diff --
    
    Yep. The identifier of the underlying `AuthenticationProvider` will not be available until after construction (as it's provided by the implementation of `getIdentifier()`), and then only if the underlying `AuthenticationProvider` is successfully instantiated.


---