You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2018/01/03 21:43:32 UTC
Re: Review Request 64825: Update packaging to latest Thrift, Mesos,
and virtualenv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64825/#review194721
-----------------------------------------------------------
Ship it!
builder/deb/ubuntu-trusty/Dockerfile
Lines 40-45 (original)
<https://reviews.apache.org/r/64825/#comment273654>
Explain the reason for removing these in the commit message.
builder/deb/ubuntu-xenial/Dockerfile
Line 40 (original)
<https://reviews.apache.org/r/64825/#comment273655>
Also here.
- Santhosh Kumar Shanmugham
On Dec. 23, 2017, 6:48 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64825/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 6:48 a.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> * A few new system deps seem to be needed since the pants update.
> * Instead of installing Thrift out of band, we can now rely on the
> bootstrapping via pants.
> * The virtualenv script is copied from the main Aurora repo.
>
>
> Diffs
> -----
>
> build-support/virtualenv 3ed5b8c26007dc8ac2db3fc3157ba323b33664f2
> builder/deb/debian-jessie/Dockerfile 1983fb603c3216d2ace726ec133b5876343cc2df
> builder/deb/ubuntu-trusty/Dockerfile 99c5481d367e9f1049bc2ecd331929bc73204442
> builder/deb/ubuntu-xenial/Dockerfile dfdce150e38d081c02b991d5a24bec768c070c63
> builder/rpm/centos-7/Dockerfile c12a61ffb0b835970e88d724ca3f70e7269f7638
> specs/debian/control df863062e53034a6f04f457cd4a204daaa2cf80b
> specs/rpm/aurora.spec e1eff9c1f6092273b95104f9f4dd106846639a8d
> test/deb/debian-jessie/provision.sh 331a26c9c60a808f941fd54ee136db817bab2789
> test/deb/ubuntu-trusty/provision.sh b9cbd438715049a0afdc85da17f79e59b870c113
> test/deb/ubuntu-xenial/provision.sh 2adb879ec967bb0f07b3b535b0707972b4ac8d1e
> test/rpm/centos-7/Vagrantfile 8342b091eeefae35a592c79cf30ab3db82c349ca
> test/rpm/centos-7/provision.sh f41ffd17aaa3eaa314d746980c4f8e56f0373f11
>
>
> Diff: https://reviews.apache.org/r/64825/diff/1/
>
>
> Testing
> -------
>
> ./build-artifact.sh builder/rpm/centos-7/ snapshot.tar.gz 0.20.0-snapshot
> ./test/test-artifact.sh test/rpm/centos-7 /repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 64825: Update packaging to latest Thrift, Mesos,
and virtualenv
Posted by Stephan Erb <se...@apache.org>.
> On Jan. 3, 2018, 10:43 p.m., Santhosh Kumar Shanmugham wrote:
> > builder/deb/ubuntu-trusty/Dockerfile
> > Lines 40-45 (original)
> > <https://reviews.apache.org/r/64825/diff/1/?file=1927256#file1927256line40>
> >
> > Explain the reason for removing these in the commit message.
done
> On Jan. 3, 2018, 10:43 p.m., Santhosh Kumar Shanmugham wrote:
> > builder/deb/ubuntu-xenial/Dockerfile
> > Line 40 (original)
> > <https://reviews.apache.org/r/64825/diff/1/?file=1927257#file1927257line41>
> >
> > Also here.
done
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64825/#review194721
-----------------------------------------------------------
On Dec. 23, 2017, 3:48 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64825/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 3:48 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> * A few new system deps seem to be needed since the pants update.
> * Instead of installing Thrift out of band, we can now rely on the
> bootstrapping via pants.
> * The virtualenv script is copied from the main Aurora repo.
>
>
> Diffs
> -----
>
> build-support/virtualenv 3ed5b8c26007dc8ac2db3fc3157ba323b33664f2
> builder/deb/debian-jessie/Dockerfile 1983fb603c3216d2ace726ec133b5876343cc2df
> builder/deb/ubuntu-trusty/Dockerfile 99c5481d367e9f1049bc2ecd331929bc73204442
> builder/deb/ubuntu-xenial/Dockerfile dfdce150e38d081c02b991d5a24bec768c070c63
> builder/rpm/centos-7/Dockerfile c12a61ffb0b835970e88d724ca3f70e7269f7638
> specs/debian/control df863062e53034a6f04f457cd4a204daaa2cf80b
> specs/rpm/aurora.spec e1eff9c1f6092273b95104f9f4dd106846639a8d
> test/deb/debian-jessie/provision.sh 331a26c9c60a808f941fd54ee136db817bab2789
> test/deb/ubuntu-trusty/provision.sh b9cbd438715049a0afdc85da17f79e59b870c113
> test/deb/ubuntu-xenial/provision.sh 2adb879ec967bb0f07b3b535b0707972b4ac8d1e
> test/rpm/centos-7/Vagrantfile 8342b091eeefae35a592c79cf30ab3db82c349ca
> test/rpm/centos-7/provision.sh f41ffd17aaa3eaa314d746980c4f8e56f0373f11
>
>
> Diff: https://reviews.apache.org/r/64825/diff/1/
>
>
> Testing
> -------
>
> ./build-artifact.sh builder/rpm/centos-7/ snapshot.tar.gz 0.20.0-snapshot
> ./test/test-artifact.sh test/rpm/centos-7 /repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64
>
>
> Thanks,
>
> Stephan Erb
>
>