You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Michael Mahemoff (JIRA)" <ji...@apache.org> on 2008/03/28 23:20:24 UTC

[jira] Created: (SHINDIG-160) Improve readability of rpc_relay.html

Improve readability of rpc_relay.html
-------------------------------------

                 Key: SHINDIG-160
                 URL: https://issues.apache.org/jira/browse/SHINDIG-160
             Project: Shindig
          Issue Type: Improvement
          Components: Sample container & Examples
            Reporter: Michael Mahemoff
            Priority: Trivial


rpc_relay.html uses a terse format with one-letter variable names. This patch is aimed at improving readability and is purely cosmetic, no functional change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-160) Improve readability of rpc_relay.html

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583215#action_12583215 ] 

Kevin Brown commented on SHINDIG-160:
-------------------------------------

This is completely intentional. If you want, feel free to include a separate README file explaining what this does, but rpc_relay *must* be as small as possible to optimize performance. This is one situation where every byte counts, and we should only be looking into ways to make the file smaller.

> Improve readability of rpc_relay.html
> -------------------------------------
>
>                 Key: SHINDIG-160
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-160
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Sample container & Examples
>            Reporter: Michael Mahemoff
>            Priority: Trivial
>         Attachments: refactor-rpc.patch
>
>
> rpc_relay.html uses a terse format with one-letter variable names. This patch is aimed at improving readability and is purely cosmetic, no functional change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-160) Improve readability of rpc_relay.html

Posted by "Michael Mahemoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Mahemoff updated SHINDIG-160:
-------------------------------------

    Attachment: refactor-rpc.patch

> Improve readability of rpc_relay.html
> -------------------------------------
>
>                 Key: SHINDIG-160
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-160
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Sample container & Examples
>            Reporter: Michael Mahemoff
>            Priority: Trivial
>         Attachments: refactor-rpc.patch
>
>
> rpc_relay.html uses a terse format with one-letter variable names. This patch is aimed at improving readability and is purely cosmetic, no functional change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-160) Improve readability of rpc_relay.html

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583222#action_12583222 ] 

Kevin Brown commented on SHINDIG-160:
-------------------------------------

You're likely correct -- I haven't looked into it in great detail recently since rpc is mostly Zhen's area. He's on vacation right now so I'd probably send him an email whenever he gets back online (I think Monday, or possibly the week after).

> Improve readability of rpc_relay.html
> -------------------------------------
>
>                 Key: SHINDIG-160
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-160
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Sample container & Examples
>            Reporter: Michael Mahemoff
>            Priority: Trivial
>         Attachments: refactor-rpc.patch
>
>
> rpc_relay.html uses a terse format with one-letter variable names. This patch is aimed at improving readability and is purely cosmetic, no functional change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SHINDIG-160) Improve readability of rpc_relay.html

Posted by "Zhen Wang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhen Wang closed SHINDIG-160.
-----------------------------

    Resolution: Fixed
      Assignee: Zhen Wang

> Improve readability of rpc_relay.html
> -------------------------------------
>
>                 Key: SHINDIG-160
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-160
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Sample container & Examples
>            Reporter: Michael Mahemoff
>            Assignee: Zhen Wang
>            Priority: Trivial
>         Attachments: refactor-rpc.patch
>
>
> rpc_relay.html uses a terse format with one-letter variable names. This patch is aimed at improving readability and is purely cosmetic, no functional change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-160) Improve readability of rpc_relay.html

Posted by "Michael Mahemoff (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583218#action_12583218 ] 

Michael Mahemoff commented on SHINDIG-160:
------------------------------------------

I see, that makes sense. I'm documenting some of the design on my blog (http://softwareas.com), so I'll make note there and eventually that content could be included in a README.

BTW There's significant whitespace that could be eliminated, if minimal length is the sole objective.

> Improve readability of rpc_relay.html
> -------------------------------------
>
>                 Key: SHINDIG-160
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-160
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Sample container & Examples
>            Reporter: Michael Mahemoff
>            Priority: Trivial
>         Attachments: refactor-rpc.patch
>
>
> rpc_relay.html uses a terse format with one-letter variable names. This patch is aimed at improving readability and is purely cosmetic, no functional change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.