You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pluto-dev@portals.apache.org by Viktor Malytskyy <vi...@rogers.com> on 2003/11/21 17:28:11 UTC

Bug in Pluto's portal

Hi!

It seems that there is a bug in 
\src\portal\org\apache\pluto\portalImpl\om\window\impl\PortletWindowListImpl.java. 
This class implements PortletWindowList interface which defines a method 
iterator().
    /**
     * Returns all *_portlet windows_* as iterator
     * The return value cannot be NULL.
     *
     * @return An iterator containing <CODE>PortletWindow</CODE> objects
     */
But in PortletWindowListImpl.java this method returns an iterator 
containing Map.Entry objects.
    public java.util.Iterator iterator() {

        return windows.entrySet().iterator();
    }

Probably it should be changed to windows.*_values()_*.iterator();

Please, correct me if  I'm wrong.

Regards,
Viktor

Re: Bug in Pluto's portal

Posted by Stefan Hepper <st...@hursley.ibm.com>.

Thanks Viktor,
right, that's a bug, fixed now.

Stefan

Viktor Malytskyy wrote:

> Hi!
> 
> It seems that there is a bug in 
> \src\portal\org\apache\pluto\portalImpl\om\window\impl\PortletWindowListImpl.java. 
> This class implements PortletWindowList interface which defines a method 
> iterator().
>    /**
>     * Returns all *_portlet windows_* as iterator
>     * The return value cannot be NULL.
>     *
>     * @return An iterator containing <CODE>PortletWindow</CODE> objects
>     */
> But in PortletWindowListImpl.java this method returns an iterator 
> containing Map.Entry objects.
>    public java.util.Iterator iterator() {
> 
>        return windows.entrySet().iterator();
>    }
> 
> Probably it should be changed to windows.*_values()_*.iterator();
> 
> Please, correct me if  I'm wrong.
> 
> Regards,
> Viktor
> 
> 
>