[GitHub] iilyak commented on a change in pull request #1468: Port bulk_docs.js

[GitBox <gi...@apache.org>]

iilyak commented on a change in pull request #1468: Port bulk_docs.js
URL: https://github.com/apache/couchdb/pull/1468#discussion_r205520887
 
 

 ##########
 File path: test/elixir/test/test_helper.exs
 ##########
 @@ -180,6 +180,10 @@ defmodule CouchTestCase do
         }
       end
 
+      def make_docs(count) do
+        make_docs(1, count)
 
 Review comment:
   There is a slight difference in behavior between JS tests and Elixir port. JS would generates ids starting from `0` (while Elixir would start from `1`). This might complicate porting of other tests if they expect to receive `_id` starting from `0`. The easiest way to fix it is to change loop in `make_docs/2`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services