[GitHub] sijie closed pull request #1499: Issue #1498: Log messages/exception text in DiskChecker shows 'used threshold' situations

[GitBox <gi...@apache.org>]

sijie closed pull request #1499: Issue #1498: Log messages/exception text in DiskChecker shows 'used <threshold' in 'used > threshold' situations
URL: https://github.com/apache/bookkeeper/pull/1499
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
index b0c7ea61d..f03d47519 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DiskChecker.java
@@ -153,17 +153,17 @@ float checkDiskFull(File dir) throws DiskOutOfSpaceException, DiskWarnThresholdE
             float free = (float) usableSpace / (float) totalSpace;
             float used = 1f - free;
             if (used > diskUsageThreshold) {
-                LOG.error("Space left on device {} : {}, Used space fraction: {} < threshold {}.",
+                LOG.error("Space left on device {} : {}, Used space fraction: {} > threshold {}.",
                         dir, usableSpace, used, diskUsageThreshold);
                 throw new DiskOutOfSpaceException("Space left on device "
-                        + usableSpace + " Used space fraction:" + used + " < threshold " + diskUsageThreshold, used);
+                        + usableSpace + " Used space fraction:" + used + " > threshold " + diskUsageThreshold, used);
             }
             // Warn should be triggered only if disk usage threshold doesn't trigger first.
             if (used > diskUsageWarnThreshold) {
-                LOG.warn("Space left on device {} : {}, Used space fraction: {} < WarnThreshold {}.",
+                LOG.warn("Space left on device {} : {}, Used space fraction: {} > WarnThreshold {}.",
                         dir, usableSpace, used, diskUsageThreshold);
                 throw new DiskWarnThresholdException("Space left on device:"
-                        + usableSpace + " Used space fraction:" + used + " < WarnThreshold:" + diskUsageWarnThreshold,
+                        + usableSpace + " Used space fraction:" + used + " > WarnThreshold:" + diskUsageWarnThreshold,
                         used);
             }
             return used;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services