You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/14 21:59:04 UTC
[GitHub] [incubator-hudi] afilipchik opened a new pull request #1517: Use
appropriate FS when loading configs
afilipchik opened a new pull request #1517: Use appropriate FS when loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517
## What is the purpose of the pull request
Minor enhancement. Currently config file must be on the same FS as hudi dataset which is not flexible. We sometimes supply it from local fs on kube.
## Brief change log
HoodieDeltaStreamer -> get FS for configs before loading.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull
request #1517: Use appropriate FS when loading configs
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on a change in pull request #1517: Use appropriate FS when loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517#discussion_r408964846
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -391,7 +391,9 @@ public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs, HiveCo
ValidationUtils.checkArgument(!cfg.filterDupes || cfg.operation != Operation.UPSERT,
"'--filter-dupes' needs to be disabled when '--op' is 'UPSERT' to ensure updates are not missed.");
- this.props = properties != null ? properties : UtilHelpers.readConfig(fs, new Path(cfg.propsFilePath), cfg.configs).getConfig();
+ this.props = properties != null ? properties : UtilHelpers.readConfig(
+ FSUtils.getFs(cfg.propsFilePath, jssc.hadoopConfiguration()),
Review comment:
Let us make it flexible in HoodieMultiTableDeltaStreamer as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] afilipchik commented on a change in pull request
#1517: Use appropriate FS when loading configs
Posted by GitBox <gi...@apache.org>.
afilipchik commented on a change in pull request #1517: Use appropriate FS when loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517#discussion_r409205392
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -391,7 +391,9 @@ public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs, HiveCo
ValidationUtils.checkArgument(!cfg.filterDupes || cfg.operation != Operation.UPSERT,
"'--filter-dupes' needs to be disabled when '--op' is 'UPSERT' to ensure updates are not missed.");
- this.props = properties != null ? properties : UtilHelpers.readConfig(fs, new Path(cfg.propsFilePath), cfg.configs).getConfig();
+ this.props = properties != null ? properties : UtilHelpers.readConfig(
+ FSUtils.getFs(cfg.propsFilePath, jssc.hadoopConfiguration()),
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1517:
[HUDI-799] Use appropriate FS when loading configs
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1517: [HUDI-799] Use appropriate FS when loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] afilipchik commented on a change in pull request
#1517: Use appropriate FS when loading configs
Posted by GitBox <gi...@apache.org>.
afilipchik commented on a change in pull request #1517: Use appropriate FS when loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517#discussion_r409206422
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -391,7 +391,9 @@ public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs, HiveCo
ValidationUtils.checkArgument(!cfg.filterDupes || cfg.operation != Operation.UPSERT,
"'--filter-dupes' needs to be disabled when '--op' is 'UPSERT' to ensure updates are not missed.");
- this.props = properties != null ? properties : UtilHelpers.readConfig(fs, new Path(cfg.propsFilePath), cfg.configs).getConfig();
+ this.props = properties != null ? properties : UtilHelpers.readConfig(
+ FSUtils.getFs(cfg.propsFilePath, jssc.hadoopConfiguration()),
Review comment:
I think it is already doing that:
` FileSystem fs = FSUtils.getFs(commonPropsFile, jssc.hadoopConfiguration());`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1517: Use
appropriate FS when loading configs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1517: Use appropriate FS when loading configs
URL: https://github.com/apache/incubator-hudi/pull/1517#issuecomment-614368160
hi @afilipchik, thanks for your contribution, we need add `[MINOR]` to title for minor changes.
e.g `[MINOR] Use appropriate FS when loading configs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services