You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ec...@apache.org on 2015/11/04 20:56:04 UTC
hbase git commit: HBASE-14723 Fix IT tests split too many times
Repository: hbase
Updated Branches:
refs/heads/branch-1.2 a80714ea3 -> 71e3125a3
HBASE-14723 Fix IT tests split too many times
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/71e3125a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/71e3125a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/71e3125a
Branch: refs/heads/branch-1.2
Commit: 71e3125a326b3df6b020405bfad342fc53845127
Parents: a80714e
Author: Elliott Clark <ec...@apache.org>
Authored: Fri Oct 30 09:14:14 2015 -0700
Committer: Elliott Clark <ec...@apache.org>
Committed: Wed Nov 4 11:55:58 2015 -0800
----------------------------------------------------------------------
.../actions/SplitAllRegionOfTableAction.java | 26 ++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/71e3125a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java
----------------------------------------------------------------------
diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java
index 3c76ebf..5b29d00 100644
--- a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java
+++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java
@@ -21,15 +21,28 @@ import org.apache.hadoop.hbase.HBaseTestingUtility;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.Admin;
+import java.io.IOException;
+import java.util.concurrent.ThreadLocalRandom;
+
public class SplitAllRegionOfTableAction extends Action {
+ private static final int DEFAULT_MAX_SPLITS = 3;
+ private static final String MAX_SPLIT_KEY = "hbase.chaosmonkey.action.maxFullTableSplits";
+
private final TableName tableName;
+ private int maxFullTableSplits = DEFAULT_MAX_SPLITS;
+ private int splits = 0;
public SplitAllRegionOfTableAction(TableName tableName) {
this.tableName = tableName;
}
+ public void init(ActionContext context) throws IOException {
+ super.init(context);
+ this.maxFullTableSplits = getConf().getInt(MAX_SPLIT_KEY, DEFAULT_MAX_SPLITS);
+ }
+
@Override
public void perform() throws Exception {
HBaseTestingUtility util = context.getHBaseIntegrationTestingUtility();
@@ -38,7 +51,16 @@ public class SplitAllRegionOfTableAction extends Action {
if (context.isStopping()) {
return;
}
- LOG.info("Performing action: Split all regions of " + tableName);
- admin.split(tableName);
+
+
+ // Don't always split. This should allow splitting of a full table later in the run
+ if (ThreadLocalRandom.current().nextDouble()
+ < (((double) splits) / ((double) maxFullTableSplits)) / ((double) 2)) {
+ splits++;
+ LOG.info("Performing action: Split all regions of " + tableName);
+ admin.split(tableName);
+ } else {
+ LOG.info("Skipping split of all regions.");
+ }
}
}