[GitHub] [jena] afs commented on pull request #872: JENA-2004 Implement functionality currently provided by Txn class directly in Transactional. Deprecate Txn class.

[GitBox <gi...@apache.org>]

afs commented on pull request #872:
URL: https://github.com/apache/jena/pull/872#issuecomment-734822362


   The top-level question is whether this adds benefit to the user community. Our user community is diverse, some people are highly skilled developers, and some are highly skilled data experts who use programming as a means to an end (and may work in several languages).
   
   `Txn` is public API and I don't think it helps to remove it.
   
   Adding default methods that call `Txn.XYZ` would be good.
   
   I also think that the traditional style begin/commit, ideally inside try-finally is what many users are familiar with, either because of JDBC experience or not really having adopted in their java the lambda functional style in their own code.
   
   So my preference is add the default methods as calls to Txn, and have the Transactional javadoc be fairly neutral in opinion (I'll adds some review comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org