You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/11/02 08:37:29 UTC
[GitHub] [mynewt-nimble] IshaESP opened a new pull request, #1403: nimble/host : Added new method of marking an api as deprecated.
IshaESP opened a new pull request, #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403
In the current code, using deprecated api's doesn't give any warnings. So, added a new way in which if these api's are used, compiler will give a warning associated with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1333426313
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/include/host/ble_gatt.h
<details>
```diff
@@ -477,7 +477,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
*/
-int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om) NIMBLE_DEPRECATED("Use ble_gatts_notify_custom instead.");
+int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om) NIMBLE_DEPRECATED(
+ "Use ble_gatts_notify_custom instead.");
/**
* Sends a characteristic notification. The content of the message is read
@@ -537,7 +538,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate instead.
*/
-int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) NIMBLE_DEPRECATED("Use ble_gatts_indicate instead.");
+int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) NIMBLE_DEPRECATED(
+ "Use ble_gatts_indicate instead.");
int ble_gattc_init(void);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1381685268
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
IshaESP commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1299889293
Hi @sjanc ,
Can you please take a look at this?
The CI checks are failing as the files where these api's are used are giving warnings which are treated as errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
IshaESP commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1306716998
> we build mynewt with -Werror so this will break build
>
> maybe this should be a macro configurable via syscfg? eg MYNEWT_VAL(WARN_ON_DEPRECATED) or similar...
Added a configurable macro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
IshaESP commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1314068026
Hi @sjanc,
Can you please take a look at this PR.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1306662449
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1306706619
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
sjanc commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1029095005
##########
nimble/host/include/host/ble_gatt.h:
##########
@@ -476,8 +477,15 @@ int ble_gatts_notify_custom(uint16_t conn_handle, uint16_t att_handle,
/**
* Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
*/
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
Review Comment:
I'd rather have this as an OPT-IN MYNEWT_VAL(BLE_WARN_DEPRECATED)
and also define makro (eg in ble_hs.h) for this and not ifdef every single function declaration
#if MYNEWT_VAL(BLE_WARN_DEPRECATED)
#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should not be used. " _msg)))
#else
#define NIMBLE_DEPRECATED(_msg)
#endif
and than just do this to deprecate
NIMBLE_DEPRECATED("use bar") void foo(void);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1299831663
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/include/host/ble_gatt.h
<details>
```diff
@@ -478,7 +478,7 @@
*/
int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle,
struct os_mbuf *om)
- __attribute__((deprecated("Deprecated. Should not be used. "
+__attribute__((deprecated("Deprecated. Should not be used. "
"Use ble_gatts_notify_custom instead.")));
/**
@@ -499,7 +499,7 @@
* Deprecated. Should not be used. Use ble_gatts_notify instead.
*/
int ble_gattc_notify(uint16_t conn_handle, uint16_t chr_val_handle)
- __attribute__((deprecated("Deprecated. Should not be used. "
+__attribute__((deprecated("Deprecated. Should not be used. "
"Use ble_gatts_notify instead.")));
/**
@@ -523,7 +523,7 @@
*/
int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t chr_val_handle,
struct os_mbuf *txom)
- __attribute__((deprecated("Deprecated. Should not be used. "
+__attribute__((deprecated("Deprecated. Should not be used. "
"Use ble_gatts_indicate_custom instead.")));
/**
@@ -544,7 +544,7 @@
* Deprecated. Should not be used. Use ble_gatts_indicate instead.
*/
int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle)
- __attribute__((deprecated("Deprecated. Should not be used. "
+__attribute__((deprecated("Deprecated. Should not be used. "
"Use ble_gatts_notify_custom instead.")));
int ble_gattc_init(void);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1333671337
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/include/host/ble_gatt.h
<details>
```diff
@@ -477,7 +477,9 @@
/**
* Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
*/
-NIMBLE_DEPRECATED("Use ble_gatts_notify_custom instead.") int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om);
+NIMBLE_DEPRECATED("Use ble_gatts_notify_custom instead.") int ble_gattc_notify_custom(uint16_t conn_handle,
+ uint16_t att_handle,
+ struct os_mbuf *om);
/**
* Sends a characteristic notification. The content of the message is read
@@ -517,7 +519,9 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate_custom instead.
*/
-NIMBLE_DEPRECATED("Use ble_gatts_indicate_custom instead.") int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t chr_val_handle, struct os_mbuf *txom);
+NIMBLE_DEPRECATED("Use ble_gatts_indicate_custom instead.") int ble_gattc_indicate_custom(uint16_t conn_handle,
+ uint16_t chr_val_handle,
+ struct os_mbuf *txom);
/**
* Sends a characteristic indication. The content of the message is read from
@@ -536,7 +540,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate instead.
*/
-NIMBLE_DEPRECATED("Use ble_gatts_indicate instead.") int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle);
+NIMBLE_DEPRECATED("Use ble_gatts_indicate instead.") int ble_gattc_indicate(uint16_t conn_handle,
+ uint16_t chr_val_handle);
int ble_gattc_init(void);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
sjanc commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1039423505
##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
/** CSRK distibution and LinkKey are not supported */
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
+#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should not be used. " _msg)))
Review Comment:
This should be the other way around... but I really think that this feature (warn on deprecate) should be opt in, ie name it BLE_WARN_ON_DEPRECATE and default to 0 and warn only if it is set to 1
##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
/** CSRK distibution and LinkKey are not supported */
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
Review Comment:
this header should include #include "syscfg/syscfg.h if it is using MYNEWT_VAL() makro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1378792885
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/include/host/ble_gatt.h
<details>
```diff
@@ -477,7 +477,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
*/
-int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om) NIMBLE_DEPRECATED("Use ble_gatts_notify_custom instead.");
+int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om) NIMBLE_DEPRECATED(
+ "Use ble_gatts_notify_custom instead.");
/**
* Sends a characteristic notification. The content of the message is read
@@ -517,7 +518,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate_custom instead.
*/
-int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t chr_val_handle, struct os_mbuf *txom) NIMBLE_DEPRECATED("Use ble_gatts_indicate_custom instead.");
+int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t chr_val_handle, struct os_mbuf *txom) NIMBLE_DEPRECATED(
+ "Use ble_gatts_indicate_custom instead.");
/**
* Sends a characteristic indication. The content of the message is read from
@@ -536,7 +538,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate instead.
*/
-int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) NIMBLE_DEPRECATED("Use ble_gatts_indicate instead.");
+int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) NIMBLE_DEPRECATED(
+ "Use ble_gatts_indicate instead.");
int ble_gattc_init(void);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1044152797
##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
/** CSRK distibution and LinkKey are not supported */
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
+#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should not be used. " _msg)))
Review Comment:
It's default value is set to 0, if someone wants to opt in they can set it to 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1332046627
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1379966011
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1044153414
##########
nimble/host/include/host/ble_gatt.h:
##########
@@ -476,8 +477,15 @@ int ble_gatts_notify_custom(uint16_t conn_handle, uint16_t att_handle,
/**
* Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
*/
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
Review Comment:
For this - NIMBLE_DEPRECATED("use bar") void foo(void); CI always fails. Tried the other way around too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1095630289
##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
/** CSRK distibution and LinkKey are not supported */
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
+#define NIMBLE_DEPRECATED(_msg) __attribute__((deprecated("Deprecated. Should not be used. " _msg)))
Review Comment:
BLE_SUPPRESS_DEPRECATE_WARN:
description: >
This suppresses deprecated warning
value: 0
Enabling warning should be opt-int, not disabling those ie:
BLE_WARN_ON_DEPRECATE:
description: >
This enabling warning on used deprecated API.
value: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] IshaESP commented on a diff in pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
IshaESP commented on code in PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#discussion_r1066725095
##########
nimble/host/include/host/ble_hs.h:
##########
@@ -184,6 +184,22 @@ extern "C" {
/** CSRK distibution and LinkKey are not supported */
+/**
+ * @}
+ */
+
+/**
+ * @brief LE deprecate warning
+ *
+ * @{
+ */
+
+#if MYNEWT_VAL(BLE_SUPPRESS_DEPRECATE_WARN)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
sjanc commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1305635025
we build mynewt with -Werror so this will break build
maybe this should be a macro configurable via syscfg? eg MYNEWT_VAL(WARN_ON_DEPRECATED) or similar...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1403: nimble/host : Added new method of marking an api as deprecated.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1403:
URL: https://github.com/apache/mynewt-nimble/pull/1403#issuecomment-1339759682
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/include/host/ble_gatt.h
<details>
```diff
@@ -477,7 +477,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_notify_custom instead.
*/
-int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om) NIMBLE_DEPRECATED("Use ble_gatts_notify_custom instead.");
+int ble_gattc_notify_custom(uint16_t conn_handle, uint16_t att_handle, struct os_mbuf *om) NIMBLE_DEPRECATED(
+ "Use ble_gatts_notify_custom instead.");
/**
* Sends a characteristic notification. The content of the message is read
@@ -517,7 +518,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate_custom instead.
*/
-int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t chr_val_handle, struct os_mbuf *txom) NIMBLE_DEPRECATED("Use ble_gatts_indicate_custom instead.");
+int ble_gattc_indicate_custom(uint16_t conn_handle, uint16_t chr_val_handle, struct os_mbuf *txom) NIMBLE_DEPRECATED(
+ "Use ble_gatts_indicate_custom instead.");
/**
* Sends a characteristic indication. The content of the message is read from
@@ -536,7 +538,8 @@
/**
* Deprecated. Should not be used. Use ble_gatts_indicate instead.
*/
-int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) NIMBLE_DEPRECATED("Use ble_gatts_indicate instead.");
+int ble_gattc_indicate(uint16_t conn_handle, uint16_t chr_val_handle) NIMBLE_DEPRECATED(
+ "Use ble_gatts_indicate instead.");
int ble_gattc_init(void);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org