[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on issue #656: (ios) Remove fake status bar with hardcoded height to fix issues in iOS devices with a notch

[GitBox <gi...@apache.org>]

PDLMobileApps commented on issue #656: (ios) Remove fake status bar with hardcoded height to fix issues in iOS devices with a notch
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/656#issuecomment-608243047
 
 
   > I did a quick test and the code looks good to me. Thank you for your contribution.
   > 
   > I found a small bug. If you open an InAppBrowser window and turn your iPhone (no notch) from portrait to horizontal the statusbar height is not changed and you can see your app below the IAB window. If you start IAB in horizontal and turn your phone the statusbar is white in my case and you cannot read the text.
   > 
   > Looks like the views need to reposition in this case.
   
   Thanks for finding this issue. It should be fixed in my last commit. I also refactored/simplified the code. In my tests if worked fine with devices with and without notch, with top toolbar enabled and disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org