[jira] [Commented] (PARQUET-2072) Do Not Determine Both Min/Max for Binary Stats

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393560#comment-17393560 ] 

ASF GitHub Bot commented on PARQUET-2072:
-----------------------------------------

belugabehr opened a new pull request #920:
URL: https://github.com/apache/parquet-mr/pull/920


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [PARQUET-2072](https://issues.apache.org/jira/browse/PARQUET-2072) issues
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No change in functionality. Use existing unit tests.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Do Not Determine Both Min/Max for Binary Stats
> ----------------------------------------------
>
>                 Key: PARQUET-2072
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2072
>             Project: Parquet
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>
> I'm looking at some benchmarking code of Apache ORC v.s. Apache Parquet and see that Parquet is quite a bit slower for writes (reads TBD).  Based on my investigation, I have noticed a significant amount of time spent in determining min/max for binary types.
> One quick improvement is to bypass a "max" value determinization if the value has already been determined to be a "min".
> While I'm at it, remove calls to deprecated functions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)