You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/07/21 20:01:06 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #4420: Enable direct loading of native library for junixsocket instead of loading from temp
matthiasblaesing opened a new pull request, #4420:
URL: https://github.com/apache/netbeans/pull/4420
junixsocket loads by default the native library using System#loadLibrary
so the native libraries only need to be placed in the
modules/lib/<arch>/<os>
folders, so that they can be loaded directly with the requirement to
expand them and load them from java.io.tmpdir.
Closes: #4393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4420:
URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1193148749
Out of interest, why the additional module dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4420:
URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1196566205
@mcdonnell-john could you possibly have a look when rc2 is ready whether this is going to cause a signing / notarization issue? I had issues with signing the junixsocket library bundled in the jar because it's built against too low a version of the macos sdk. However, the jar passed notarization then. It's possible the unbundled libraries might cause an issue though. If they do, we might need to consider either a workaround or upgrade to 2.5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4420:
URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1193184355
I did a smoke test on mac OS (amd64) - git integration with the ssh agent still works there also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4420:
URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1193159342
> Out of interest, why the additional module dependencies?
Artifacts from a first try. I tried to follow the JNA example to closely (the JNA module is using a module Installer, which junixsocket does not need). I removed the installer and the manifest changes, regrettably the changes to the dependencies were retained. I pushed an updated PR.
The corresponding binary: https://doppel-helix.eu/NetBeans-dev-dev-97f2a4617b23c157eee90abbcb6159fd9bda188f-release.zip
This does not invalidate tests done with the original change, as the depencies are not the critical path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4420:
URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1193160117
Thanks @matthiasblaesing - had a feeling the JNA ModuleInstall was the reason. :smile:
Will let the tests go green again and merge for rc2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4420:
URL: https://github.com/apache/netbeans/pull/4420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4420: Enable direct loading of native library for junixsocket instead of loading from temp
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4420:
URL: https://github.com/apache/netbeans/pull/4420#issuecomment-1202288384
@matthiasblaesing OK, verified this is now failing notarization on macOS. Opened issue #4460 Any concerns with updating to 2.5.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists