[GitHub] [activemq-artemis] gtully commented on a change in pull request #3635: ARTEMIS-2007 - allow redistribution if there are unmatched messages p…

[GitBox <gi...@apache.org>]

gtully commented on a change in pull request #3635:
URL: https://github.com/apache/activemq-artemis/pull/3635#discussion_r662328293



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -3066,7 +3073,7 @@ private boolean deliver() {
             } else if (!consumers.hasNext()) {
                // Round robin'd all
 
-               if (noDelivery == this.consumers.size()) {
+               if (noDelivery == consumerCount) {

Review comment:
       I had the same worries because my motivation was just to avoid a second related call to size() b/c the logic of seeing noDelivery every where is what I need, it depends on consumers not changing. I can peek some more to get a better answer.
   thanks for the shared concern :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org