You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/05/05 11:31:53 UTC
[GitHub] [airflow] potiuk opened a new issue, #31087: Latest Botocore breaks SQS tests
potiuk opened a new issue, #31087:
URL: https://github.com/apache/airflow/issues/31087
### Body
Our tests are broken in main due to latest botocore failing SQS tests.
Example here: https://github.com/apache/airflow/actions/runs/4887737387/jobs/8724954226
```
E botocore.exceptions.ClientError: An error occurred (400) when calling the SendMessage operation: <ErrorResponse xmlns="http://queue.amazonaws.com/doc/2012-11-05/"><Error><Type>Sender</Type><Code>AWS.SimpleQueueService.NonExistentQueue</Code><Message>The specified queue does not exist for this wsdl version.</Message><Detail/></Error><RequestId>ETDUP0OoJOXmn0WS6yWmB0dOhgYtpdVJCVwFWA28lYLKLmGJLAGu</RequestId></ErrorResponse>
```
The problem seems to come from botocore not recognizing just added queue:
```
QUEUE_NAME = "test-queue"
QUEUE_URL = f"https://{QUEUE_NAME}"
```
Even if we replace it with the full queue name that gets returned by the "create_queue" API call to `moto`, it still does not work with latest botocore:
```
QUEUE_URL = f"https://sqs.us-east-1.amazonaws.com/123456789012/{QUEUE_NAME}"
```
Which indicates this likely a real botocore issue.
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536500997
Those steps reproducibly failed for me @o-nikolas :D.. Maybe it is "if in amazon = works" :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536518625
Okay, cool, we should be able close this now (unless we want to keep it open until moto releases a fix).
The related celery+SQS issues wont affect any CI here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536573887
I am subscribing to the issues to get notified when they are fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536508413
> Those steps reproducibly failed for me @o-nikolas :D.. Maybe it is "if in amazon = works" :D
From your steps above I see 11 passed?
```
"Result:
============ 11 passed in 4.57s =======
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536512596
I separate those two "fail/pass" scenario more visibly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536473154
Just checking in now. The repro steps you have here has all the tests passing, I'd suspect something to be failing? Looking into it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536632832
Or we can just not use moto in `tests/providers/amazon/aws/sensors/test_sqs.py`. Only 4 tests are using moto. [Personal opinion]I never liked moto anyway[/Personal opinion]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536505551
Actually looks like it's just the new botocore does not play well with moto - https://github.com/boto/botocore/issues/2930 so it's not as bad (for AWS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #31087: Latest Botocore breaks SQS tests
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #31087: Latest Botocore breaks SQS tests
URL: https://github.com/apache/airflow/issues/31087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajastro commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536476730
https://github.com/apache/airflow/pull/31094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536510041
> Actually looks like it's just the new botocore does not play well with moto - [boto/botocore#2930](https://github.com/boto/botocore/issues/2930) so it's not as bad (for AWS).
Yeah, moto is hardcoding to XML wire protocol, SQS has switched to JSON only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536488639
So. It is this https://github.com/getmoto/moto/issues/6286 -> thanks @pankajastro for finding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536573606
Yeah, Let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rbishund commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "rbishund (via GitHub)" <gi...@apache.org>.
rbishund commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536668962
There is a new version of botocore 1.29.128 that resolves the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536511400
> ===== 4 failed, 7 passed in 2.43s ===
> > Those steps reproducibly failed for me @o-nikolas :D.. Maybe it is "if in amazon = works" :D
>
> From your steps above I see 11 passed?
>
> ```
> "Result:
>
> ============ 11 passed in 4.57s =======
> ```
But few steps above (with different botocore version):
===== 4 failed, 7 passed in 2.43s ===
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536504147
Following along on this. It does appear that the issue is with the latest botocore version not playing well with the new SQS API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536682395
PR reverting the workaround: https://github.com/apache/airflow/pull/31103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #31087: Latest Botocore breaks SQS tests
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #31087:
URL: https://github.com/apache/airflow/issues/31087#issuecomment-1536130160
Possibly you can help @ferruzzi @o-nikolas @vincbeck captured it here.
I tried to fix it thinking this is a test framework issue and debugged it a bit (hence I know what full queue URL is returned when "create_queue" is called with moto, but this is as far as I could get without knowing the internals and since I used the "full URL" in my tests, I believe this might be a real issue in botocore library (but here my "explore, debug and fix tests" approach hit some limit).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org