You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by devaraj-kavali <gi...@git.apache.org> on 2018/10/03 23:18:44 UTC
[GitHub] spark pull request #22625: [SPARK-25637][CORE] SparkException: Could not fin...
GitHub user devaraj-kavali opened a pull request:
https://github.com/apache/spark/pull/22625
[SPARK-25637][CORE] SparkException: Could not find CoarseGrainedScheduler occurs during the application stop
## What changes were proposed in this pull request?
If the driverEndpointStopped is stopped, with this PR CoarseGrainedSchedulerBackend will not send reviveOffers message to the driverEndpoint.
## How was this patch tested?
Verified this manually, 'org.apache.spark.SparkException: Could not find CoarseGrainedScheduler' error is not occurring after applying this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/devaraj-kavali/spark SPARK-25637
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22625
----
commit e868aa325c7adbfbac412147edd43d7cf11179e1
Author: Devaraj K <de...@...>
Date: 2018-10-03T23:15:27Z
[SPARK-25637][CORE] SparkException: Could not find
CoarseGrainedScheduler occurs during the application stop
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22625: [SPARK-25637][CORE] SparkException: Could not find Coars...
Posted by devaraj-kavali <gi...@git.apache.org>.
Github user devaraj-kavali commented on the issue:
https://github.com/apache/spark/pull/22625
Thanks @felixcheung for looking into this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22625: [SPARK-25637][CORE] SparkException: Could not find Coars...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22625
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22625: [SPARK-25637][CORE] SparkException: Could not fin...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22625#discussion_r222550195
--- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ---
@@ -98,6 +98,8 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
private val reviveThread =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("driver-revive-thread")
+ private var driverEndpointStopped = false
--- End diff --
shouldn't this be inside class DriverEndpoint?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22625: [SPARK-25637][CORE] SparkException: Could not fin...
Posted by devaraj-kavali <gi...@git.apache.org>.
Github user devaraj-kavali commented on a diff in the pull request:
https://github.com/apache/spark/pull/22625#discussion_r222786641
--- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ---
@@ -98,6 +98,8 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
private val reviveThread =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("driver-revive-thread")
+ private var driverEndpointStopped = false
--- End diff --
If we keep the `driverEndpointStopped` inside `DriverEndpoint`, need to have another var for `DriverEndpoint` ref from `rpcEnv.setupEndpoint(ENDPOINT_NAME, createDriverEndpoint(properties))` to access the `DriverEndpoint.driverEndpointStopped`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22625: [SPARK-25637][CORE] SparkException: Could not find Coars...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22625
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22625: [SPARK-25637][CORE] SparkException: Could not find Coars...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22625
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org