[GitHub] [spark] zhengruifeng commented on a diff in pull request #42891: [SPARK-45135][PYTHON][TESTS] Make `utils.eventually` a parameterized decorator

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #42891:
URL: https://github.com/apache/spark/pull/42891#discussion_r1325205015


##########
python/pyspark/testing/utils.py:
##########
@@ -80,7 +83,7 @@ def eventually(condition, timeout=30.0, catch_assertions=False):
     ----------
     condition : function
         Function that checks for termination conditions. condition() can return:
-            - True: Conditions met. Return without error.
+            - True or None: Conditions met. Return without error.

Review Comment:
   @HyukjinKwon I made a change here, so that we don't need `return True` for most cases in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org