[GitHub] [celix] rlenferink commented on a change in pull request #353: Feature/pubsub interceptor fix

[GitBox <gi...@apache.org>]

rlenferink commented on a change in pull request #353:
URL: https://github.com/apache/celix/pull/353#discussion_r681798722



##########
File path: bundles/pubsub/examples/CMakeLists.txt
##########
@@ -221,10 +221,10 @@ if (BUILD_PUBSUB_PSA_ZMQ)
         BUNDLES
             Celix::shell
             Celix::shell_tui
-            Celix::pubsub_serializer_json
-            Celix::pubsub_discovery_etcd
-            Celix::pubsub_topology_manager
-            Celix::pubsub_admin_zmq
+            Celix::celix_pubsub_serializer_json
+            Celix::celix_pubsub_discovery_etcd
+            Celix::celix_pubsub_topology_manager
+            Celix::celix_pubsub_admin_zmq

Review comment:
       just for my information: why the rename of the bundles to include `celix_` if they are already part of the `Celix` group?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org