You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org> on 2018/11/18 08:58:05 UTC
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3036
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
[ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- When recycling a buffer, calculate the buffer remaining before
releasing it for reuse to prevent other threads from changing
its remaining.
Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppHdfsExecutionTest.java
A asterixdb/asterix-app/src/test/resources/runtimets/only_sqlpp_hdfs.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_hdfs.xml
M asterixdb/asterix-external-data/pom.xml
M asterixdb/asterix-metadata/pom.xml
M asterixdb/asterix-om/pom.xml
M asterixdb/asterix-test-framework/pom.xml
M asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/xml/TestSuiteParser.java
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml
M hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml
M hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/LicenseUtil.java
M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
M hyracks-fullstack/pom.xml
19 files changed, 329 insertions(+), 283 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/36/3036/1
diff --git a/asterixdb/asterix-app/pom.xml b/asterixdb/asterix-app/pom.xml
index 440ef14..8c25235 100644
--- a/asterixdb/asterix-app/pom.xml
+++ b/asterixdb/asterix-app/pom.xml
@@ -476,6 +476,10 @@
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs-client</artifactId>
+ </dependency>
+ <dependency>
<groupId>org.apache.hyracks</groupId>
<artifactId>algebricks-data</artifactId>
</dependency>
@@ -494,7 +498,6 @@
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
- <scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
index 62c882d..4ed36c6 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java
@@ -52,7 +52,7 @@
}
public static List<ILibraryManager> setUp(boolean cleanup, String configFile) throws Exception {
- return setUp(cleanup, configFile, integrationUtil, true, null);
+ return setUp(cleanup, configFile, integrationUtil, false, null);
}
public static List<ILibraryManager> setUp(boolean cleanup, String configFile,
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
index cd270cd..75eccfd 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/LangExecutionUtil.java
@@ -19,6 +19,7 @@
package org.apache.asterix.test.runtime;
+import static org.apache.asterix.test.runtime.ExecutionTestUtil.integrationUtil;
import static org.apache.hyracks.util.ThreadDumpUtil.takeDumpJSONString;
import java.io.BufferedReader;
@@ -61,10 +62,15 @@
private static boolean checkStorageDistribution = true;
public static void setUp(String configFile, TestExecutor executor) throws Exception {
+ setUp(configFile, executor, false);
+ }
+
+ public static void setUp(String configFile, TestExecutor executor, boolean startHdfs) throws Exception {
testExecutor = executor;
File outdir = new File(PATH_ACTUAL);
outdir.mkdirs();
- List<ILibraryManager> libraryManagers = ExecutionTestUtil.setUp(cleanupOnStart, configFile);
+ List<ILibraryManager> libraryManagers =
+ ExecutionTestUtil.setUp(cleanupOnStart, configFile, integrationUtil, startHdfs, null);
ExternalUDFLibrarian.removeLibraryDir();
librarian = new ExternalUDFLibrarian(libraryManagers);
testExecutor.setLibrarian(librarian);
@@ -82,7 +88,7 @@
} finally {
ExternalUDFLibrarian.removeLibraryDir();
ExecutionTestUtil.tearDown(cleanupOnStop);
- ExecutionTestUtil.integrationUtil.removeTestStorageFiles();
+ integrationUtil.removeTestStorageFiles();
if (!badTestCases.isEmpty()) {
System.out.println("The following test cases left some data");
for (String testCase : badTestCases) {
@@ -140,7 +146,7 @@
// Checks whether data files are uniformly distributed among io devices.
private static void checkStorageFiles() throws Exception {
- NodeControllerService[] ncs = ExecutionTestUtil.integrationUtil.ncs;
+ NodeControllerService[] ncs = integrationUtil.ncs;
// Checks that dataset files are uniformly distributed across each io device.
for (NodeControllerService nc : ncs) {
checkNcStore(nc);
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppHdfsExecutionTest.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppHdfsExecutionTest.java
new file mode 100644
index 0000000..6ea87ef
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppHdfsExecutionTest.java
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.test.runtime;
+
+import java.util.Collection;
+
+import org.apache.asterix.test.common.TestExecutor;
+import org.apache.asterix.testframework.context.TestCaseContext;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
+
+/**
+ * Runs the SQL++ runtime tests with the storage parallelism.
+ */
+@RunWith(Parameterized.class)
+public class SqlppHdfsExecutionTest {
+ protected static final String TEST_CONFIG_FILE_NAME = "src/main/resources/cc.conf";
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+ LangExecutionUtil.setUp(TEST_CONFIG_FILE_NAME, new TestExecutor(), true);
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+ LangExecutionUtil.tearDown();
+ }
+
+ @Parameters(name = "SqlppHdfsExecutionTest {index}: {0}")
+ public static Collection<Object[]> tests() throws Exception {
+ return LangExecutionUtil.tests("only_sqlpp_hdfs.xml", "testsuite_sqlpp_hdfs.xml");
+ }
+
+ protected TestCaseContext tcCtx;
+
+ public SqlppHdfsExecutionTest(TestCaseContext tcCtx) {
+ this.tcCtx = tcCtx;
+ }
+
+ @Test
+ public void test() throws Exception {
+ LangExecutionUtil.test(tcCtx);
+ }
+}
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/only_sqlpp_hdfs.xml b/asterixdb/asterix-app/src/test/resources/runtimets/only_sqlpp_hdfs.xml
new file mode 100644
index 0000000..334dd52
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/only_sqlpp_hdfs.xml
@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<!--
+ ! Licensed to the Apache Software Foundation (ASF) under one
+ ! or more contributor license agreements. See the NOTICE file
+ ! distributed with this work for additional information
+ ! regarding copyright ownership. The ASF licenses this file
+ ! to you under the Apache License, Version 2.0 (the
+ ! "License"); you may not use this file except in compliance
+ ! with the License. You may obtain a copy of the License at
+ !
+ ! http://www.apache.org/licenses/LICENSE-2.0
+ !
+ ! Unless required by applicable law or agreed to in writing,
+ ! software distributed under the License is distributed on an
+ ! "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ! KIND, either express or implied. See the License for the
+ ! specific language governing permissions and limitations
+ ! under the License.
+ !-->
+<test-suite xmlns="urn:xml.testframework.asterix.apache.org" ResultOffsetPath="results" QueryOffsetPath="queries_sqlpp" QueryFileExtension=".sqlpp">
+ <test-group name="failed">
+ </test-group>
+</test-suite>
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
index d42cfce..91becf7 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
@@ -39,38 +39,6 @@
</compilation-unit>
</test-case>
</test-group>
- <test-group name="external-indexing">
- <test-case FilePath="external-indexing">
- <compilation-unit name="text-format">
- <output-dir compare="Text">text-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="sequence-format">
- <output-dir compare="Text">sequence-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="rc-format">
- <output-dir compare="Text">rc-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
<test-group name="upsert">
<test-case FilePath="upsert">
<compilation-unit name="filtered-dataset">
@@ -3545,28 +3513,6 @@
</compilation-unit>
</test-case>
</test-group>
- <test-group name="open-index-enforced/external-indexing">
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="adm-format">
- <output-dir compare="Text">adm-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
<test-group name="open-index-enforced/type-checking">
<test-case FilePath="open-index-enforced/type-checking">
<compilation-unit name="enforced-type-delete">
@@ -3724,28 +3670,6 @@
<test-case FilePath="nested-open-index/index-selection">
<compilation-unit name="rtree-secondary-index">
<output-dir compare="Text">rtree-secondary-index</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
- <test-group name="nested-open-index/external-indexing">
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="adm-format">
- <output-dir compare="Text">adm-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
</compilation-unit>
</test-case>
</test-group>
@@ -3976,28 +3900,6 @@
<test-case FilePath="nested-index/index-selection">
<compilation-unit name="rtree-secondary-index-open">
<output-dir compare="Text">rtree-secondary-index-open</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
- <test-group name="nested-index/external-indexing">
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="adm-format">
- <output-dir compare="Text">adm-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
</compilation-unit>
</test-case>
</test-group>
@@ -6639,40 +6541,8 @@
</compilation-unit>
</test-case>
<test-case FilePath="hints">
- <compilation-unit name="issue_251_dataset_hint_6">
- <output-dir compare="Text">issue_251_dataset_hint_6</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hints">
<compilation-unit name="issue_251_dataset_hint_7">
<output-dir compare="Text">issue_251_dataset_hint_7</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
- <test-group name="hdfs">
- <test-case FilePath="hdfs">
- <compilation-unit name="large-record">
- <output-dir compare="Text">large-record</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="hdfs_shortcircuit">
- <output-dir compare="Text">hdfs_shortcircuit</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="issue_245_hdfs">
- <output-dir compare="Text">issue_245_hdfs</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="hdfs_02">
- <output-dir compare="Text">hdfs_02</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="hdfs_03">
- <output-dir compare="Text">hdfs_03</output-dir>
</compilation-unit>
</test-case>
</test-group>
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 0127896..f5a2ab4 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -4195,28 +4195,6 @@
</compilation-unit>
</test-case>
</test-group>
- <test-group name="open-index-enforced/external-indexing">
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="adm-format">
- <output-dir compare="Text">adm-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="open-index-enforced/external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
<test-group name="open-index-enforced/type-checking">
<test-case FilePath="open-index-enforced/type-checking">
<compilation-unit name="enforced-type-delete">
@@ -4408,28 +4386,6 @@
<test-case FilePath="nested-open-index/index-selection">
<compilation-unit name="rtree-secondary-index">
<output-dir compare="Text">rtree-secondary-index</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
- <test-group name="nested-open-index/external-indexing">
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="adm-format">
- <output-dir compare="Text">adm-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-open-index/external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
</compilation-unit>
</test-case>
</test-group>
@@ -4670,28 +4626,6 @@
<test-case FilePath="nested-index/index-selection">
<compilation-unit name="rtree-secondary-index-optional">
<output-dir compare="Text">rtree-secondary-index-open</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
- <test-group name="nested-index/external-indexing">
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="adm-format">
- <output-dir compare="Text">adm-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="nested-index/external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
</compilation-unit>
</test-case>
</test-group>
@@ -6848,11 +6782,6 @@
</compilation-unit>
</test-case>
<test-case FilePath="subquery">
- <compilation-unit name="decorrelate_with_unique_id_2">
- <output-dir compare="Text">decorrelate_with_unique_id_2</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="subquery">
<compilation-unit name="exists">
<output-dir compare="Text">exists</output-dir>
</compilation-unit>
@@ -8815,11 +8744,6 @@
</compilation-unit>
</test-case>
<test-case FilePath="hints">
- <compilation-unit name="issue_251_dataset_hint_6">
- <output-dir compare="Text">issue_251_dataset_hint_6</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hints">
<compilation-unit name="issue_251_dataset_hint_7">
<output-dir compare="Text">issue_251_dataset_hint_7</output-dir>
</compilation-unit>
@@ -9085,28 +9009,6 @@
</compilation-unit>
</test-case>
</test-group>
- <test-group name="hdfs">
- <test-case FilePath="hdfs">
- <compilation-unit name="hdfs_shortcircuit">
- <output-dir compare="Text">hdfs_shortcircuit</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="issue_245_hdfs">
- <output-dir compare="Text">issue_245_hdfs</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="hdfs_02">
- <output-dir compare="Text">hdfs_02</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="hdfs">
- <compilation-unit name="hdfs_03">
- <output-dir compare="Text">hdfs_03</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
<test-group name="big-object">
<test-case FilePath="big-object">
<compilation-unit name="big_object_sort">
@@ -9131,38 +9033,6 @@
<test-case FilePath="big-object">
<compilation-unit name="big_object_load_20M">
<output-dir compare="Text">big_object_load_20M</output-dir>
- </compilation-unit>
- </test-case>
- </test-group>
- <test-group name="external-indexing">
- <test-case FilePath="external-indexing">
- <compilation-unit name="text-format">
- <output-dir compare="Text">text-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="sequence-format">
- <output-dir compare="Text">sequence-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="rc-format">
- <output-dir compare="Text">rc-format</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="rtree-index">
- <output-dir compare="Text">rtree-index</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="leftouterjoin">
- <output-dir compare="Text">leftouterjoin</output-dir>
- </compilation-unit>
- </test-case>
- <test-case FilePath="external-indexing">
- <compilation-unit name="leftouterjoin-rtree">
- <output-dir compare="Text">leftouterjoin-rtree</output-dir>
</compilation-unit>
</test-case>
</test-group>
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_hdfs.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_hdfs.xml
new file mode 100644
index 0000000..45b36d0
--- /dev/null
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_hdfs.xml
@@ -0,0 +1,160 @@
+<!--
+ ! Licensed to the Apache Software Foundation (ASF) under one
+ ! or more contributor license agreements. See the NOTICE file
+ ! distributed with this work for additional information
+ ! regarding copyright ownership. The ASF licenses this file
+ ! to you under the Apache License, Version 2.0 (the
+ ! "License"); you may not use this file except in compliance
+ ! with the License. You may obtain a copy of the License at
+ !
+ ! http://www.apache.org/licenses/LICENSE-2.0
+ !
+ ! Unless required by applicable law or agreed to in writing,
+ ! software distributed under the License is distributed on an
+ ! "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ! KIND, either express or implied. See the License for the
+ ! specific language governing permissions and limitations
+ ! under the License.
+ !-->
+<test-suite xmlns="urn:xml.testframework.asterix.apache.org" ResultOffsetPath="results" QueryOffsetPath="queries_sqlpp" QueryFileExtension=".sqlpp" SourceLocation="true">
+ <test-group name="open-index-enforced">
+ <test-group name="open-index-enforced/external-indexing">
+ <test-case FilePath="open-index-enforced/external-indexing">
+ <compilation-unit name="adm-format">
+ <output-dir compare="Text">adm-format</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="open-index-enforced/external-indexing">
+ <compilation-unit name="rtree-index">
+ <output-dir compare="Text">rtree-index</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="open-index-enforced/external-indexing">
+ <compilation-unit name="leftouterjoin">
+ <output-dir compare="Text">leftouterjoin</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="open-index-enforced/external-indexing">
+ <compilation-unit name="leftouterjoin-rtree">
+ <output-dir compare="Text">leftouterjoin-rtree</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+ </test-group>
+ <test-group name="nested-open-index">
+ <test-group name="nested-open-index/external-indexing">
+ <test-case FilePath="nested-open-index/external-indexing">
+ <compilation-unit name="adm-format">
+ <output-dir compare="Text">adm-format</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="nested-open-index/external-indexing">
+ <compilation-unit name="rtree-index">
+ <output-dir compare="Text">rtree-index</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="nested-open-index/external-indexing">
+ <compilation-unit name="leftouterjoin">
+ <output-dir compare="Text">leftouterjoin</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="nested-open-index/external-indexing">
+ <compilation-unit name="leftouterjoin-rtree">
+ <output-dir compare="Text">leftouterjoin-rtree</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+ </test-group>
+ <test-group name="nested-index">
+ <test-group name="nested-index/external-indexing">
+ <test-case FilePath="nested-index/external-indexing">
+ <compilation-unit name="adm-format">
+ <output-dir compare="Text">adm-format</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="nested-index/external-indexing">
+ <compilation-unit name="rtree-index">
+ <output-dir compare="Text">rtree-index</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="nested-index/external-indexing">
+ <compilation-unit name="leftouterjoin">
+ <output-dir compare="Text">leftouterjoin</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="nested-index/external-indexing">
+ <compilation-unit name="leftouterjoin-rtree">
+ <output-dir compare="Text">leftouterjoin-rtree</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+ </test-group>
+ <test-group name="subquery">
+ <test-case FilePath="subquery">
+ <compilation-unit name="decorrelate_with_unique_id_2">
+ <output-dir compare="Text">decorrelate_with_unique_id_2</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+ <test-group name="hints">
+ <test-case FilePath="hints">
+ <compilation-unit name="issue_251_dataset_hint_6">
+ <output-dir compare="Text">issue_251_dataset_hint_6</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+ <test-group name="hdfs">
+ <test-case FilePath="hdfs">
+ <compilation-unit name="hdfs_shortcircuit">
+ <output-dir compare="Text">hdfs_shortcircuit</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="hdfs">
+ <compilation-unit name="issue_245_hdfs">
+ <output-dir compare="Text">issue_245_hdfs</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="hdfs">
+ <compilation-unit name="hdfs_02">
+ <output-dir compare="Text">hdfs_02</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="hdfs">
+ <compilation-unit name="hdfs_03">
+ <output-dir compare="Text">hdfs_03</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+ <test-group name="external-indexing">
+ <test-case FilePath="external-indexing">
+ <compilation-unit name="text-format">
+ <output-dir compare="Text">text-format</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="external-indexing">
+ <compilation-unit name="sequence-format">
+ <output-dir compare="Text">sequence-format</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="external-indexing">
+ <compilation-unit name="rc-format">
+ <output-dir compare="Text">rc-format</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="external-indexing">
+ <compilation-unit name="rtree-index">
+ <output-dir compare="Text">rtree-index</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="external-indexing">
+ <compilation-unit name="leftouterjoin">
+ <output-dir compare="Text">leftouterjoin</output-dir>
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="external-indexing">
+ <compilation-unit name="leftouterjoin-rtree">
+ <output-dir compare="Text">leftouterjoin-rtree</output-dir>
+ </compilation-unit>
+ </test-case>
+ </test-group>
+</test-suite>
diff --git a/asterixdb/asterix-external-data/pom.xml b/asterixdb/asterix-external-data/pom.xml
index a73ac92..74d2def 100644
--- a/asterixdb/asterix-external-data/pom.xml
+++ b/asterixdb/asterix-external-data/pom.xml
@@ -420,10 +420,14 @@
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
</dependency>
- <dependency>
- <groupId>com.esri.geometry</groupId>
- <artifactId>esri-geometry-api</artifactId>
- <version>2.0.0</version>
- </dependency>
+ <dependency>
+ <groupId>com.esri.geometry</groupId>
+ <artifactId>esri-geometry-api</artifactId>
+ <version>2.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ </dependency>
</dependencies>
</project>
diff --git a/asterixdb/asterix-metadata/pom.xml b/asterixdb/asterix-metadata/pom.xml
index 94c2668..510bae0 100644
--- a/asterixdb/asterix-metadata/pom.xml
+++ b/asterixdb/asterix-metadata/pom.xml
@@ -169,15 +169,15 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs-client</artifactId>
+ </dependency>
</dependencies>
</project>
diff --git a/asterixdb/asterix-om/pom.xml b/asterixdb/asterix-om/pom.xml
index 3be3e2f..75628b7 100644
--- a/asterixdb/asterix-om/pom.xml
+++ b/asterixdb/asterix-om/pom.xml
@@ -127,5 +127,10 @@
<artifactId>esri-geometry-api</artifactId>
<version>2.0.0</version>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
diff --git a/asterixdb/asterix-test-framework/pom.xml b/asterixdb/asterix-test-framework/pom.xml
index 2025d5a..188e4d9 100644
--- a/asterixdb/asterix-test-framework/pom.xml
+++ b/asterixdb/asterix-test-framework/pom.xml
@@ -78,6 +78,14 @@
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </dependency>
</dependencies>
</project>
diff --git a/asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/xml/TestSuiteParser.java b/asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/xml/TestSuiteParser.java
index 201945c..8939bd1 100644
--- a/asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/xml/TestSuiteParser.java
+++ b/asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/xml/TestSuiteParser.java
@@ -29,17 +29,27 @@
import javax.xml.parsers.SAXParserFactory;
import javax.xml.transform.sax.SAXSource;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.xml.sax.InputSource;
import org.xml.sax.SAXException;
+import org.xml.sax.SAXNotRecognizedException;
+import org.xml.sax.SAXNotSupportedException;
public class TestSuiteParser {
+
+ private static final Logger LOGGER = LogManager.getLogger();
public TestSuite parse(File testSuiteCatalog) throws SAXException, JAXBException, ParserConfigurationException {
SAXParserFactory saxParserFactory = SAXParserFactory.newInstance();
saxParserFactory.setNamespaceAware(true);
saxParserFactory.setXIncludeAware(true);
SAXParser saxParser = saxParserFactory.newSAXParser();
- saxParser.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, "file");
+ try {
+ saxParser.setProperty(XMLConstants.ACCESS_EXTERNAL_DTD, "file");
+ } catch (SAXNotRecognizedException | SAXNotSupportedException e) {
+ LOGGER.warn("ignoring exception setting sax parser property", e);
+ }
JAXBContext ctx = JAXBContext.newInstance(TestSuite.class);
Unmarshaller um = ctx.createUnmarshaller();
diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index 3d8d805..0c7c19d 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -75,7 +75,7 @@
<!-- Versions under dependencymanagement or used in many projects via properties -->
<algebricks.version>0.3.4-SNAPSHOT</algebricks.version>
<hyracks.version>0.3.4-SNAPSHOT</hyracks.version>
- <hadoop.version>2.2.0</hadoop.version>
+ <hadoop.version>2.8.5</hadoop.version>
<jacoco.version>0.7.6.201602180812</jacoco.version>
<implementation.title>Apache AsterixDB - ${project.name}</implementation.title>
@@ -321,7 +321,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.7.0</version>
+ <version>3.8.0</version>
</plugin>
<!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
<plugin>
@@ -798,7 +798,8 @@
<jdk>11</jdk>
</activation>
<properties>
- <target.jdk.version>11</target.jdk.version>
+ <!-- several plugins do not yet support Java 11 classes (maven-plugin-plugin, maven-dependency-plugin) -->
+ <target.jdk.version>10</target.jdk.version>
</properties>
</profile>
<profile>
@@ -936,6 +937,11 @@
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs-client</artifactId>
+ <version>${hadoop.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>${hadoop.version}</version>
<classifier>tests</classifier>
diff --git a/hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml b/hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml
index 61235ca..406f566 100644
--- a/hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-dataflow-common/pom.xml
@@ -83,6 +83,11 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
diff --git a/hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml b/hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml
index 409abbd..9c6d09d 100644
--- a/hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-hdfs/pom.xml
@@ -192,5 +192,11 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.3.04</version>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
diff --git a/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/LicenseUtil.java b/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/LicenseUtil.java
index 2a34fc7..1476326 100644
--- a/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/LicenseUtil.java
+++ b/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/src/main/java/org/apache/hyracks/maven/license/LicenseUtil.java
@@ -109,7 +109,7 @@
while (trimmed.length() > wrapLength) {
int cut = trimmed.lastIndexOf(' ', wrapLength);
cut = Math.max(cut, trimmed.lastIndexOf('\t', wrapLength));
- if (cut != -1) {
+ if (cut != -1 && cut > leadingWS) {
out.append(trimmed.substring(0, cut));
out.append('\n');
trimmed = trimmed.substring(cut + 1);
diff --git a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
index 32bf77e..054acb6 100644
--- a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
+++ b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
@@ -45,8 +45,8 @@
if (ccb.isRemotelyClosed()) {
return;
}
- riEmptyStack.push(buffer);
final int delta = buffer.remaining();
+ riEmptyStack.push(buffer);
ccb.addPendingCredits(delta);
};
}
diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml
index 1d52cc8..a734ffc 100644
--- a/hyracks-fullstack/pom.xml
+++ b/hyracks-fullstack/pom.xml
@@ -65,7 +65,7 @@
<test.includes>${global.test.includes}</test.includes>
<test.excludes>${global.test.excludes}</test.excludes>
<!-- Versions under dependencymanagement or used in many projects via properties -->
- <hadoop.version>2.2.0</hadoop.version>
+ <hadoop.version>2.8.5</hadoop.version>
<jacoco.version>0.7.6.201602180812</jacoco.version>
<implementation.title>Apache Hyracks and Algebricks - ${project.name}</implementation.title>
@@ -215,6 +215,11 @@
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<version>2.0.2-beta</version>
+ </dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <version>2.3.0</version>
</dependency>
</dependencies>
</dependencyManagement>
@@ -425,7 +430,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.7.0</version>
+ <version>3.8.0</version>
</plugin>
<plugin>
<groupId>org.apache.rat</groupId>
@@ -730,7 +735,8 @@
<jdk>11</jdk>
</activation>
<properties>
- <target.jdk.version>11</target.jdk.version>
+ <!-- several plugins do not yet support Java 11 classes (maven-plugin-plugin, maven-dependency-plugin) -->
+ <target.jdk.version>10</target.jdk.version>
</properties>
</profile>
<profile>
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4760/ (5/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5092/ (9/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5093/ (1/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4663/ (10/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7579/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4981/ (7/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2770/ (3/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4974/ (8/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4754/ (7/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5100/ (11/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4973/ (5/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8708/ (2/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4726/ (4/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7586/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5139/ (5/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5330/ (9/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10233/ (1/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8701/ (2/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1: Contrib-2
Analytics Compatibility Tests Failed
https://goo.gl/7KuAe2 : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5138/ (8/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7579/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5322/ (11/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2: Contrib+1
Analytics Compatibility Tests Successful
https://goo.gl/sBUReN : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://goo.gl/FSncH5 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4718/ (4/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10234/ (11/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4753/ (10/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4762/ (1/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Analytics Compatibility Compilation Successful
https://goo.gl/6mbmve : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4719/ (7/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4671/ (10/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5323/ (9/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2763/ (6/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4752/ (6/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8700/ (2/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10241/ (6/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5146/ (8/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2762/ (3/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3: Contrib+1
Analytics Compatibility Tests Successful
https://goo.gl/de3cjD : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4755/ (4/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has submitted this change and it was merged.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
[ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- When recycling a buffer, calculate the buffer remaining before
releasing it for reuse to prevent other threads from changing
its remaining.
- Add test case.
Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3036
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <ti...@apache.org>
---
M hyracks-fullstack/hyracks/hyracks-net/pom.xml
M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
A hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
3 files changed, 188 insertions(+), 2 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git a/hyracks-fullstack/hyracks/hyracks-net/pom.xml b/hyracks-fullstack/hyracks/hyracks-net/pom.xml
index 1040e81..4ca20ca 100644
--- a/hyracks-fullstack/hyracks/hyracks-net/pom.xml
+++ b/hyracks-fullstack/hyracks/hyracks-net/pom.xml
@@ -60,5 +60,11 @@
<artifactId>hyracks-util</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-all</artifactId>
+ <version>2.0.2-beta</version>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
diff --git a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
index 32bf77e..3ba8627 100644
--- a/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
+++ b/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
@@ -36,7 +36,7 @@
private final BlockingDeque<ByteBuffer> riEmptyStack;
private final IChannelControlBlock ccb;
- FullFrameChannelReadInterface(IChannelControlBlock ccb) {
+ public FullFrameChannelReadInterface(IChannelControlBlock ccb) {
this.ccb = ccb;
riEmptyStack = new LinkedBlockingDeque<>();
credits = 0;
@@ -45,8 +45,8 @@
if (ccb.isRemotelyClosed()) {
return;
}
- riEmptyStack.push(buffer);
final int delta = buffer.remaining();
+ riEmptyStack.push(buffer);
ccb.addPendingCredits(delta);
};
}
diff --git a/hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java b/hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
new file mode 100644
index 0000000..f9a610c
--- /dev/null
+++ b/hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hyracks.net.tests;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.channels.SocketChannel;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingDeque;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.apache.hyracks.api.comm.IBufferFactory;
+import org.apache.hyracks.api.comm.IChannelControlBlock;
+import org.apache.hyracks.api.comm.ICloseableBufferAcceptor;
+import org.apache.hyracks.net.protocols.muxdemux.ChannelControlBlock;
+import org.apache.hyracks.net.protocols.muxdemux.FullFrameChannelReadInterface;
+import org.apache.hyracks.util.StorageUtil;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.mockito.Mockito;
+
+@RunWith(Parameterized.class)
+public class FullFrameChannelReadInterfaceTest {
+
+ private static final int TEST_RUNS = 100;
+ private static final int RECEIVER_BUFFER_COUNT = 50;
+ private static int FRAMES_TO_READ_COUNT = 10000;
+ private static final int FRAME_SIZE = StorageUtil.getIntSizeInBytes(32, StorageUtil.StorageUnit.KILOBYTE);
+ private static final int EXPECTED_CHANNEL_CREDIT = FRAME_SIZE * RECEIVER_BUFFER_COUNT;
+
+ @Parameterized.Parameters
+ public static Object[][] data() {
+ return new Object[TEST_RUNS][0];
+ }
+
+ @Test
+ public void bufferRecycleTest() throws Exception {
+ final AtomicInteger channelCredit = new AtomicInteger();
+ final IChannelControlBlock ccb = mockChannelControlBlock(channelCredit);
+ final ReadBufferFactory bufferFactory = new ReadBufferFactory(RECEIVER_BUFFER_COUNT, FRAME_SIZE);
+ final FullFrameChannelReadInterface readInterface = new FullFrameChannelReadInterface(ccb);
+ final LinkedBlockingDeque<ByteBuffer> fullBufferQ = new LinkedBlockingDeque<>();
+ readInterface.setFullBufferAcceptor(new ReadFullBufferAcceptor(fullBufferQ));
+ readInterface.setBufferFactory(bufferFactory, RECEIVER_BUFFER_COUNT, FRAME_SIZE);
+ Assert.assertEquals(EXPECTED_CHANNEL_CREDIT, channelCredit.get());
+ final SocketChannel socketChannel = mockSocketChannel(ccb);
+ final Thread networkFrameReader = new Thread(() -> {
+ try {
+ int framesRead = FRAMES_TO_READ_COUNT;
+ while (framesRead > 0) {
+ while (channelCredit.get() == 0) {
+ synchronized (channelCredit) {
+ channelCredit.wait(10000);
+ if (channelCredit.get() == 0) {
+ System.err.println("Sender doesn't have any write credit");
+ System.exit(1);
+ }
+ }
+ }
+ readInterface.read(socketChannel, FRAME_SIZE);
+ framesRead--;
+ }
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
+ });
+
+ final Thread frameProcessor = new Thread(() -> {
+ int framesProcessed = 0;
+ try {
+ while (true) {
+ final ByteBuffer fullFrame = fullBufferQ.take();
+ fullFrame.clear();
+ readInterface.getEmptyBufferAcceptor().accept(fullFrame);
+ framesProcessed++;
+ if (framesProcessed == FRAMES_TO_READ_COUNT) {
+ return;
+ }
+ }
+ } catch (InterruptedException e) {
+ e.printStackTrace();
+ }
+ });
+ networkFrameReader.start();
+ frameProcessor.start();
+ networkFrameReader.join();
+ frameProcessor.join();
+ if (channelCredit.get() != EXPECTED_CHANNEL_CREDIT) {
+ System.err
+ .println("Expected channel credit " + EXPECTED_CHANNEL_CREDIT + " , found " + channelCredit.get());
+ System.exit(1);
+ }
+ }
+
+ private IChannelControlBlock mockChannelControlBlock(AtomicInteger credit) {
+ final ChannelControlBlock ccb = Mockito.mock(ChannelControlBlock.class);
+ Mockito.when(ccb.isRemotelyClosed()).thenReturn(false);
+ Mockito.doAnswer(invocation -> {
+ final Integer delta = invocation.getArgumentAt(0, Integer.class);
+ credit.addAndGet(delta);
+ synchronized (credit) {
+ credit.notifyAll();
+ }
+ return null;
+ }).when(ccb).addPendingCredits(Mockito.anyInt());
+ return ccb;
+ }
+
+ private SocketChannel mockSocketChannel(IChannelControlBlock ccb) throws IOException {
+ final SocketChannel sc = Mockito.mock(SocketChannel.class);
+ Mockito.when(sc.read(Mockito.any(ByteBuffer.class))).thenAnswer(invocation -> {
+ ccb.addPendingCredits(-FRAME_SIZE);
+ final ByteBuffer buffer = invocation.getArgumentAt(0, ByteBuffer.class);
+ while (buffer.hasRemaining()) {
+ buffer.put((byte) 0);
+ }
+ return FRAME_SIZE;
+ });
+ return sc;
+ }
+
+ private class ReadFullBufferAcceptor implements ICloseableBufferAcceptor {
+ private final BlockingQueue<ByteBuffer> fullBufferQ;
+
+ ReadFullBufferAcceptor(BlockingQueue<ByteBuffer> fullBuffer) {
+ this.fullBufferQ = fullBuffer;
+ }
+
+ @Override
+ public void accept(ByteBuffer buffer) {
+ fullBufferQ.add(buffer);
+ }
+
+ @Override
+ public void close() {
+ }
+
+ @Override
+ public void error(int ecode) {
+ }
+ }
+
+ public class ReadBufferFactory implements IBufferFactory {
+ private final int limit;
+ private final int frameSize;
+ private int counter = 0;
+
+ ReadBufferFactory(int limit, int frameSize) {
+ this.limit = limit;
+ this.frameSize = frameSize;
+ }
+
+ @Override
+ public ByteBuffer createBuffer() {
+ if (counter >= limit) {
+ throw new IllegalStateException("Buffer limit exceeded");
+ }
+ counter++;
+ return ByteBuffer.allocate(frameSize);
+ }
+ }
+}
\ No newline at end of file
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4664/ (3/11)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2:
Analytics Compatibility Compilation Successful
https://goo.gl/YnGm25 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/3036
to look at the new patch set (#3).
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
[ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- When recycling a buffer, calculate the buffer remaining before
releasing it for reuse to prevent other threads from changing
its remaining.
- Add test case.
Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
---
M hyracks-fullstack/hyracks/hyracks-net/pom.xml
M hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/muxdemux/FullFrameChannelReadInterface.java
A hyracks-fullstack/hyracks/hyracks-net/src/test/java/org/apache/hyracks/net/tests/FullFrameChannelReadInterfaceTest.java
3 files changed, 188 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/36/3036/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Anon. E. Moose (Code Review)" <do...@asterixdb.incubator.apache.org>.
Anon. E. Moose #1000171 has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 2: Contrib-2
Analytics Compatibility Tests Failed
https://goo.gl/9KRxFN : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reus...
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: [ASTERIXDB-2478][NET] Calculate Buffer Remaining Before Reusing It
......................................................................
Patch Set 3:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7586/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3036
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca3284feae800dd6c37694bdefec3516cd4c506
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No