You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/09 21:11:40 UTC
[GitHub] [hadoop] arp7 commented on a change in pull request #1230:
HDDS-1895. Support Key ACL operations for OM HA.
arp7 commented on a change in pull request #1230: HDDS-1895. Support Key ACL operations for OM HA.
URL: https://github.com/apache/hadoop/pull/1230#discussion_r312649376
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java
##########
@@ -141,20 +144,26 @@ private static OMClientRequest getOMAclRequest(OMRequest omRequest) {
return new OMVolumeAddAclRequest(omRequest);
} else if (ObjectType.BUCKET == type) {
return new OMBucketAddAclRequest(omRequest);
+ } else if (type == ObjectType.KEY) {
Review comment:
The code is using reverse order for equality. Can you use the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org