You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/12/20 19:20:35 UTC

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19381


Change subject: IMPALA-10803: Change default cache eviction policy to LIRS
......................................................................

IMPALA-10803: Change default cache eviction policy to LIRS

This changes the default value of data_cache_eviction_policy
to LIRS.

Testing:
 - Ran core tests with data caching

Change-Id: Ic2250386b41e599c2bc0f8e8cc12a29a5f1a3f00
---
M be/src/runtime/io/data-cache.cc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/19381/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2250386b41e599c2bc0f8e8cc12a29a5f1a3f00
Gerrit-Change-Number: 19381
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19381 )

Change subject: IMPALA-10803: Change default cache eviction policy to LIRS
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2250386b41e599c2bc0f8e8cc12a29a5f1a3f00
Gerrit-Change-Number: 19381
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 28 Jan 2023 04:56:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19381 )

Change subject: IMPALA-10803: Change default cache eviction policy to LIRS
......................................................................


Patch Set 1:

What have you done to evaluate the performance implications of this?


-- 
To view, visit http://gerrit.cloudera.org:8080/19381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2250386b41e599c2bc0f8e8cc12a29a5f1a3f00
Gerrit-Change-Number: 19381
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 19:22:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19381 )

Change subject: IMPALA-10803: Change default cache eviction policy to LIRS
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12047/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2250386b41e599c2bc0f8e8cc12a29a5f1a3f00
Gerrit-Change-Number: 19381
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Dec 2022 19:40:18 +0000
Gerrit-HasComments: No