You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/09/03 09:41:02 UTC

[jira] Created: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

review plugins use of expression and change to default-value/component where appropriate
----------------------------------------------------------------------------------------

         Key: MNG-830
         URL: http://jira.codehaus.org/browse/MNG-830
     Project: Maven 2
        Type: Improvement
 Reporter: Brett Porter
     Fix For: 2.0-beta-2


we also need a good explanation written down of the difference.

* default-value is used when expression is null
* expression is intended to be used to get the user's override, eg from a system property

Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "allan ramirez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-830?page=all ]

allan ramirez updated MNG-830:
------------------------------

    Remaining Estimate: 2 hours
     Original Estimate: 7200

> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Brett Porter
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4

>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-830?page=all ]

Brett Porter updated MNG-830:
-----------------------------

    Fix Version:     (was: 2.0-beta-3)
                 2.0-beta-4

> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement
>     Reporter: Brett Porter
>      Fix For: 2.0-beta-4

>
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-830?page=all ]

John Casey updated MNG-830:
---------------------------

    Fix Version:     (was: 2.0.1)
                 2.0.2

> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement
>     Reporter: Brett Porter
>     Assignee: Allan Ramirez
>      Fix For: 2.0.2
>  Attachments: MNG-830.patch
>
> Original Estimate: 2 hours
>        Time Spent: 2 hours, 20 minutes
>         Remaining: 0 minutes
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "allan ramirez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-830?page=all ]

allan ramirez updated MNG-830:
------------------------------

    Attachment: MNG-830.patch

>From the clover plugin, I found the usage of expression to be
     /**
      * @parameter expression=""
      */
     private String licenseFile;


Since expression value is null, I removed the expression word to be like this
     /**
      * @parameter
      */
     private String licenseFile;




> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Brett Porter
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-830.patch
>
> Original Estimate: 2 hours
>         Remaining: 2 hours
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-830?page=all ]

John Casey updated MNG-830:
---------------------------

    Fix Version:     (was: 2.0.3)
                 2.0.4

> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement

>     Reporter: Brett Porter
>     Assignee: Allan Ramirez
>      Fix For: 2.0.4
>  Attachments: MNG-830.patch
>
> Original Estimate: 2 hours
>        Time Spent: 2 hours, 20 minutes
>         Remaining: 0 minutes
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-830?page=all ]

Brett Porter updated MNG-830:
-----------------------------

    Component: maven-plugins

> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Brett Porter
>      Fix For: 2.0-beta-4

>
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-830) review plugins use of expression and change to default-value/component where appropriate

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-830?page=comments#action_48329 ] 

Brett Porter commented on MNG-830:
----------------------------------

applied patch

> review plugins use of expression and change to default-value/component where appropriate
> ----------------------------------------------------------------------------------------
>
>          Key: MNG-830
>          URL: http://jira.codehaus.org/browse/MNG-830
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Brett Porter
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-830.patch
>
> Original Estimate: 2 hours
>        Time Spent: 2 hours, 20 minutes
>         Remaining: 0 minutes
>
> we also need a good explanation written down of the difference.
> * default-value is used when expression is null
> * expression is intended to be used to get the user's override, eg from a system property
> Perhaps if we could cover that other use case differently (eg by a standard system property mechanism that went [plugin-prefix.goal.configuration]), we could eliminate expression altogether in a future version of Maven.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org