You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yf13 (via GitHub)" <gi...@apache.org> on 2024/07/24 08:28:33 UTC

[PR] virtio/serial: initial CONSOLE support [nuttx]

yf13 opened a new pull request, #12760:
URL: https://github.com/apache/nuttx/pull/12760

   ## Summary
   
   This adds initial support to allow virtio serial device being used as console on QEMU `rv-virt` device. It includes the following changes:
   
   - virtio/serial: add `VIRTIO_SERIAL_CONSOLE` Kconfig and support.
   - qemu-rv_start: guard u16550 uses with `HAVE_16550_CONSOLE`.
   - rv-virt_appinit: probe virtio devices upon BOARD_EARLY_INIITIALIZE
   
   ## Impacts
   
   None
   
   ## Testing
   
   - Local checks on `rv-virt`
   - CI checks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#discussion_r1690720672


##########
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##########
@@ -184,10 +184,14 @@ void qemu_rv_start(int mhartid, const char *dtb)
 
 void riscv_earlyserialinit(void)
 {
+#ifdef HAVE_16550_CONSOLE

Review Comment:
   You could replace `HAVE_16550_CONSOLE` with `CONFIG_16550_UART`
   Refer to: https://github.com/apache/nuttx/blob/master/arch/risc-v/src/k230/k230_start.c#L178-L190



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2249347503

   @anchao, thanks for all the in-line comments! I've updated them,
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2249273247

   > @anchao, thanks for your comments!
   > 
   > I am wondering that serial devices like `uart_16550`, `uart_pl011`, `serial_rtt`, `cdcacm` are quite standard, thus there is no need to treat them as arch specific devices? I feel `virtio-serial` is also quite standard, thus we can treat it more like `uart_16550`?
   
   @yf13 Your changes are correct, I missed that the tty device is also registered in this driver, please ignore my comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2251140019

   @yf13 please take a look:
   ```
   ====================================================================================
   Configuration/Tool: rv-virt/ksmp64
   2024-07-25 16:00:35
   ------------------------------------------------------------------------------------
     Cleaning...
   HEAD detached at pull/12760/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   boards/risc-v/qemu-rv/rv-virt/configs/virt_nsh/defconfig
   
   no changes added to commit (use "git add" and/or "git commit -a")
     Configuring...
     Building NuttX...
   /github/workspace/sources/apps /github/workspace/sources/nuttx
   ##[debug]Dropping file value '/home/runner/work/nuttx/nuttx/fpu.c'. Path does not exist
   Warning: fpu.c:55:8: warning: #warning "FPU test not built; Only available in the flat build (CONFIG_BUILD_FLAT)" [-Wcpp]
      55 | #      warning "FPU test not built; Only available in the flat build (CONFIG_BUILD_FLAT)"
         |        ^~~~~~~
   /github/workspace/sources/nuttx
     Normalize rv-virt/ksmp64
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "CV-Bowen (via GitHub)" <gi...@apache.org>.
CV-Bowen commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2250124835

   @yf13 https://github.com/apache/nuttx/pull/12764 Hi, how about support custom the virtio serial device name, and register the console based on the device name (/dev/console).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#discussion_r1690726978


##########
drivers/virtio/virtio-serial.c:
##########
@@ -558,6 +562,15 @@ static int virtio_serial_probe(FAR struct virtio_device *vdev)
       goto err_with_init;
     }
 
+#ifdef CONFIG_VIRTIO_SERIAL_CONSOLE
+  if (!g_virtio_console)

Review Comment:
   ```suggestion
     if (g_virtio_console == NULL)
   ```



##########
drivers/virtio/virtio-serial.c:
##########
@@ -558,6 +562,15 @@ static int virtio_serial_probe(FAR struct virtio_device *vdev)
       goto err_with_init;
     }
 
+#ifdef CONFIG_VIRTIO_SERIAL_CONSOLE
+  if (!g_virtio_console)
+    {
+      DEBUGVERIFY(uart_register("/dev/console", &priv->udev));

Review Comment:
   Should the `isconsole` flag be updated in uart driver?
   https://github.com/apache/nuttx/blob/master/drivers/serial/uart_16550.c#L1729



##########
drivers/virtio/virtio-serial.c:
##########
@@ -595,3 +608,26 @@ int virtio_register_serial_driver(void)
   int ret2 = virtio_register_driver(&g_virtio_rprocserial_driver);
   return ret1 < 0 ? ret1 : ret2;
 }
+
+#ifdef CONFIG_VIRTIO_SERIAL_CONSOLE
+/****************************************************************************
+ * Name: up_putc
+ ****************************************************************************/
+
+int up_putc(int ch)
+{
+  if (g_virtio_console)

Review Comment:
   ```suggestion
     if (g_virtio_console != NULL)
   ```



##########
drivers/virtio/Kconfig:
##########
@@ -74,6 +74,14 @@ if DRIVERS_VIRTIO_SERIAL
 config DRIVERS_VIRTIO_SERIAL_BUFSIZE
 	int "Virtio serial driver buffer size"
 	default 256
+
+config VIRTIO_SERIAL_CONSOLE

Review Comment:
   ```suggestion
   config DRIVERS_VIRTIO_SERIAL_CONSOLE
   ```



##########
drivers/virtio/virtio-serial.c:
##########
@@ -132,6 +132,10 @@ static const struct uart_ops_s g_virtio_serial_ops =
 
 static int g_virtio_serial_idx = 0;
 
+#ifdef CONFIG_VIRTIO_SERIAL_CONSOLE
+static struct uart_dev_s *g_virtio_console = 0;

Review Comment:
   ```suggestion
   static struct uart_dev_s *g_virtio_console;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2248234327

   > @acassis, it seems that I've found the way to use virtio-serial as normal console now, so it is no longer output only. I still need time to clean up the conf and then update the `rv-virt` document later.
   
   @yf13 are you using busy await reading (like the LWL console) ? We need to find a way to avoid it, because it eats too much processing time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2248746293

   @yf13 suggestion: instead nsh_aux why don't you use virt_nsh ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2250536733

   These two commits are completely different features, why drop this PR reuse #12764? #12764 was committed as early as "9 Jan 2024", why not submit it earlier ? We need to respect the work of every independent developer, not deny it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2247778490

   > @yf13 please include Documentation/
   
   @acassis, yes will do that after a concrete config is available, so far I want take this chance to review the basic changes and make sure I use virtio serial driver correctly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2247456684

   @yf13 please include Documentation/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2247930848

   @acassis, it seems that I've found the way to use virtio-serial as normal console now, so we no longer need the `output only` warnings. I still need time to clean up the conf and then update the `rv-virt` document later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2247557182

   > @yf13 please include Documentation/
   Will do that later with a concrete config. I want use this chance to learn more about the virtio-serial driver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12760:
URL: https://github.com/apache/nuttx/pull/12760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#discussion_r1690635145


##########
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##########
@@ -184,10 +184,14 @@ void qemu_rv_start(int mhartid, const char *dtb)
 
 void riscv_earlyserialinit(void)
 {
+#ifdef HAVE_16550_CONSOLE

Review Comment:
   u16550 driver initialize should not depends console



##########
drivers/virtio/virtio-serial.c:
##########
@@ -595,3 +608,26 @@ int virtio_register_serial_driver(void)
   int ret2 = virtio_register_driver(&g_virtio_rprocserial_driver);
   return ret1 < 0 ? ret1 : ret2;
 }
+
+#ifdef CONFIG_VIRTIO_SERIAL_CONSOLE

Review Comment:
   ditto



##########
drivers/virtio/virtio-serial.c:
##########
@@ -558,6 +562,15 @@ static int virtio_serial_probe(FAR struct virtio_device *vdev)
       goto err_with_init;
     }
 
+#ifdef CONFIG_VIRTIO_SERIAL_CONSOLE

Review Comment:
   Why not instantiate the console in the board code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2251140810

   ##[debug]Dropping file value '/home/runner/work/nuttx/nuttx/fpu.c'. Path does not exist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#discussion_r1691502450


##########
drivers/virtio/virtio-serial.c:
##########
@@ -558,6 +562,16 @@ static int virtio_serial_probe(FAR struct virtio_device *vdev)
       goto err_with_init;
     }
 
+#ifdef CONFIG_DRIVERS_VIRTIO_SERIAL_CONSOLE
+  if (g_virtio_console == NULL)
+    {
+      DEBUGVERIFY(uart_register("/dev/console", &priv->udev));

Review Comment:
   it's better to drop this change and utilize this general approach: https://github.com/apache/nuttx/pull/12764



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2251608814

   @acassis, thanks for reminding. It looks fpu.c warning is fine. It was my bad forgetting `tools/refresh.sh` the `virt_nsh` conf after taking @anchao's suggestion.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2249220503

   @anchao, thanks for your comments!
   
   I am wondering that serial devices like `uart_16550`, `uart_pl011`, `serial_rtt`, `cddcacm` are quite standard and popular, thus there is no need to treat them as arch specific devices? I feel `virtio-serial` is also quite standard, thus I am treaing it like `uart_16550`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#discussion_r1690661542


##########
arch/risc-v/src/qemu-rv/qemu_rv_start.c:
##########
@@ -184,10 +184,14 @@ void qemu_rv_start(int mhartid, const char *dtb)
 
 void riscv_earlyserialinit(void)
 {
+#ifdef HAVE_16550_CONSOLE

Review Comment:
   With the `virt_nsh` config, 16550 isn't enabled at all, thus we got error like below if that guard is removed:
   
   ```
   arch/risc-v/src/qemu-rv/qemu_rv_start.c:79: undefined reference to `u16550_earlyserialinit'
   collect2: error: ld returned 1 exit status
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#discussion_r1689496217


##########
drivers/virtio/Kconfig:
##########
@@ -74,6 +74,14 @@ if DRIVERS_VIRTIO_SERIAL
 config DRIVERS_VIRTIO_SERIAL_BUFSIZE
 	int "Virtio serial driver buffer size"
 	default 256
+
+config VIRTIO_SERIAL_CONSOLE
+	bool "Virtio serial console"
+	default n
+	select SERIAL_CONSOLE
+	---help---
+		This enables using first virtio serial device as console

Review Comment:
   Please include the information that it is output only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2247557722

   > @yf13 please include Documentation/
   
   Will do that later with a concrete config. I want use this chance to learn more about the virtio-serial driver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2249153456

   @acassis config renamed to `virt_nsh`
   
   But it seems [imx9-sdimage.img](https://github.com/apache/nuttx/actions/runs/10082420944/job/27884276518) has been leaked somewhere? It might block other PR as well. I saw .gitignore already contains a line for that file, but not sure if that is enough?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2250566350

   > These two commits are completely different features, why drop this PR reuse #12764? #12764 was committed as early as "9 Jan 2024", why not submit it earlier ? We need to respect the work of every independent developer, not deny it.
   
   You are 100% right! "Release early, release often!"
   
   I think we need to respect individual contributor and respect the order the PRs are created.
   
   This one here has priority, please apply this here and ask your developer to adapt his PR later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2249220891

   @anchao, thanks for your comments!
   
   I am wondering that serial devices like `uart_16550`, `uart_pl011`, `serial_rtt`, `cddcacm` are quite standard and popular, thus there is no need to treat them as arch specific devices? I feel `virtio-serial` is also quite standard, thus we can treat it like `uart_16550`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] virtio/serial: initial CONSOLE support [nuttx]

Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on PR #12760:
URL: https://github.com/apache/nuttx/pull/12760#issuecomment-2249229721

   @anchao, thanks for your comments!
   
   I am wondering that serial devices like `uart_16550`, `uart_pl011`, `serial_rtt`, `cdcacm` are quite standard, thus there is no need to treat them as arch specific devices? I feel `virtio-serial` is also quite standard, thus we can treat it more like `uart_16550`?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org