You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/07/26 09:41:00 UTC

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1020: Zookeeper 3457

nkalmar commented on a change in pull request #1020: Zookeeper 3457
URL: https://github.com/apache/zookeeper/pull/1020#discussion_r307667484
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
 ##########
 @@ -619,14 +619,21 @@ public void toSend(Long sid, ByteBuffer b) {
              /*
               * Start a new connection if doesn't have one already.
               */
-             ArrayBlockingQueue<ByteBuffer> bq = new ArrayBlockingQueue<ByteBuffer>(
+             /*ArrayBlockingQueue<ByteBuffer> bq = new ArrayBlockingQueue<ByteBuffer>(
 
 Review comment:
   Please don't push commented out code. That's what git is for, to keep history.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services