Re: [PR] HIVE-29578: Iceberg: add support for native views [hive]

["difin (via GitHub)" <gi...@apache.org>]

difin commented on code in PR #6449:
URL: https://github.com/apache/hive/pull/6449#discussion_r3189888841


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateViewAnalyzer.java:
##########
@@ -191,6 +202,40 @@ private List<FieldSchema> getPartitionColumns(List<String> partitionColumnNames)
     return partitionColumnsCopy;
   }
 
+  /**
+   * Optional trailing {@code tableFileFormat} on CREATE VIEW: only {@code STORED BY ICEBERG} is allowed
+   * (no serde properties or {@code STORED AS} tail).
+   */
+  private boolean validateOptionalViewStorageClause(ASTNode storageRoot) throws SemanticException {

Review Comment:
   Create a rule `viewMetadataFormat`. 
   
   - Moved `STORED BY ICEBERG` closer to the view definition similar to CTAS. i.e.  `STORED BY ICEBERG as SELECT.
   - Made STORED BY ICEBERG optional. if not specified, deducting the type based on `hive.default.storage.handler.class` conf.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org