You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2013/09/11 21:41:58 UTC
Re: [1/3] git commit: WICKET-5201 removed deprecated keys MinimumValidator.*
Since there is no @Deprecated for resource bundle entries, I think many
users may not know about this in 6.x.
An entry in the migration guide is needed, IMO.
On Wed, Sep 11, 2013 at 1:02 PM, <sv...@apache.org> wrote:
> Updated Branches:
> refs/heads/master 66605e518 -> d86d00967
>
>
> WICKET-5201 removed deprecated keys MinimumValidator.*
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/557cc852
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/557cc852
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/557cc852
>
> Branch: refs/heads/master
> Commit: 557cc852fee44410e63a5f44c9ee920a1ff05f61
> Parents: 66605e5
> Author: svenmeier <sv...@meiers.net>
> Authored: Wed Sep 11 11:45:00 2013 +0200
> Committer: svenmeier <sv...@meiers.net>
> Committed: Wed Sep 11 11:45:00 2013 +0200
>
> ----------------------------------------------------------------------
> .../validation/validator/RangeValidator.java | 24 --------------------
> 1 file changed, 24 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/557cc852/wicket-core/src/main/java/org/apache/wicket/validation/validator/RangeValidator.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-core/src/main/java/org/apache/wicket/validation/validator/RangeValidator.java
> b/wicket-core/src/main/java/org/apache/wicket/validation/validator/RangeValidator.java
> index 0fcb83d..712a287 100644
> ---
> a/wicket-core/src/main/java/org/apache/wicket/validation/validator/RangeValidator.java
> +++
> b/wicket-core/src/main/java/org/apache/wicket/validation/validator/RangeValidator.java
> @@ -19,8 +19,6 @@ package org.apache.wicket.validation.validator;
> import java.io.Serializable;
>
> import org.apache.wicket.validation.IValidatable;
> -import org.apache.wicket.validation.IValidationError;
> -import org.apache.wicket.validation.ValidationError;
>
> /**
> * Validator for checking if a given value falls within [min,max] range.
> @@ -114,26 +112,4 @@ public class RangeValidator<Z extends Comparable<?
> super Z> & Serializable> exte
> {
> return validatable.getValue();
> }
> -
> - @Override
> - protected IValidationError decorate(IValidationError error,
> IValidatable<Z> validatable)
> - {
> - // TODO wicket 7: remove deprecated keys
> - error = super.decorate(error, validatable);
> -
> - if (error instanceof ValidationError)
> - {
> - ValidationError ve = (ValidationError) error;
> - switch (getMode())
> - {
> - case MINIMUM :
> - ve.addKey("MinimumValidator");
> - break;
> - case MAXIMUM :
> - ve.addKey("MaximumValidator");
> - break;
> - }
> - }
> - return error;
> - }
> }
> \ No newline at end of file
>
>