You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/04/02 01:00:34 UTC

Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/
-----------------------------------------------------------

(Updated April 1, 2015, 11 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Summary (updated)
-----------------

Replace busy loop on ready file with a more relaxed loop


Bugs: mesos-2332
    https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
-------

Replace busy loop on ready file with a more relaxed loop


Diffs
-----

  src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 

Diff: https://reviews.apache.org/r/32653/diff/


Testing
-------

make check


Thanks,

Paul Brett


Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/#review78637
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32653]

All tests passed.

- Mesos ReviewBot


On April 1, 2015, 11 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32653/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 11 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace busy loop on ready file with a more relaxed loop
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 
> 
> Diff: https://reviews.apache.org/r/32653/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32653/#review78666
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On April 1, 2015, 11 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32653/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 11 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace busy loop on ready file with a more relaxed loop
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 
> 
> Diff: https://reviews.apache.org/r/32653/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>