You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "M.-Leander Reimer (JIRA)" <ji...@codehaus.org> on 2008/05/21 15:04:21 UTC

[jira] Created: (MECLIPSE-453) Generated Eclipse WTP application.xml only correct for J2EE 1.4 version

Generated Eclipse WTP application.xml only correct for J2EE 1.4 version
-----------------------------------------------------------------------

                 Key: MECLIPSE-453
                 URL: http://jira.codehaus.org/browse/MECLIPSE-453
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: WTP support
    Affects Versions: 2.5.1
         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse Europa 3.3.2, Maven 2.0.8
            Reporter: M.-Leander Reimer
         Attachments: EclipseWtpApplicationXMLWriter.java

The generated Eclipse WTP application.xml has a hard coded header and does not respect the actual JEE version used, so for JEE5 the header should look like the following 

<application xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/application_5.xsd" id="Application_ID" version="5">

instead of 

<application xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/application_1_4.xsd" id="Application_ID" version="1.4">

The required, minimal changes are in the method createNewApplicationXml() in the class EclipseWtpApplicationXMLWriter.java 
Unfortunately I could not compile and test the 2.5.1 source from SVN on my machine (the plugin unit tests failed), but I attached the changed file anyway.

Best regards,
Leander

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-453) Generated Eclipse WTP application.xml only correct for J2EE 1.4 version

Posted by "Vianney Carel (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270473#comment-270473 ] 

Vianney Carel commented on MECLIPSE-453:
----------------------------------------

Hi, the bug is still there in 2.9-SNAPSHOT. Has the patch been integrated in the trunk ?
By the way, I don't think the patch will work for JEE6.

Otherwise, why the plugin doesn't take the application.xml which is generated at target/ ... that one is correct, isn't it ?
 

> Generated Eclipse WTP application.xml only correct for J2EE 1.4 version
> -----------------------------------------------------------------------
>
>                 Key: MECLIPSE-453
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-453
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse Europa 3.3.2, Maven 2.0.8
>            Reporter: M.-Leander Reimer
>         Attachments: EclipseWtpApplicationXMLWriter.java, JavaEE5.patch
>
>
> The generated Eclipse WTP application.xml has a hard coded header and does not respect the actual JEE version used, so for JEE5 the header should look like the following 
> <application xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/application_5.xsd" id="Application_ID" version="5">
> instead of 
> <application xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/application_1_4.xsd" id="Application_ID" version="1.4">
> The required, minimal changes are in the method createNewApplicationXml() in the class EclipseWtpApplicationXMLWriter.java 
> Unfortunately I could not compile and test the 2.5.1 source from SVN on my machine (the plugin unit tests failed), but I attached the changed file anyway.
> Best regards,
> Leander

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-453) Generated Eclipse WTP application.xml only correct for J2EE 1.4 version

Posted by "Carsten Mjartan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216239#action_216239 ] 

Carsten Mjartan commented on MECLIPSE-453:
------------------------------------------

It would be nice to have this fixed, as it prevents correct WTP3 deployment of Java EE 5 EARs (at least in our project)

> Generated Eclipse WTP application.xml only correct for J2EE 1.4 version
> -----------------------------------------------------------------------
>
>                 Key: MECLIPSE-453
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-453
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse Europa 3.3.2, Maven 2.0.8
>            Reporter: M.-Leander Reimer
>         Attachments: EclipseWtpApplicationXMLWriter.java
>
>
> The generated Eclipse WTP application.xml has a hard coded header and does not respect the actual JEE version used, so for JEE5 the header should look like the following 
> <application xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/application_5.xsd" id="Application_ID" version="5">
> instead of 
> <application xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/application_1_4.xsd" id="Application_ID" version="1.4">
> The required, minimal changes are in the method createNewApplicationXml() in the class EclipseWtpApplicationXMLWriter.java 
> Unfortunately I could not compile and test the 2.5.1 source from SVN on my machine (the plugin unit tests failed), but I attached the changed file anyway.
> Best regards,
> Leander

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-453) Generated Eclipse WTP application.xml only correct for J2EE 1.4 version

Posted by "Carsten Mjartan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=250432#action_250432 ] 

Carsten Mjartan commented on MECLIPSE-453:
------------------------------------------

@Anthony: You could deploy your own patched version of the maven-eclipse-plugin to your local team repository - that's what we did


> Generated Eclipse WTP application.xml only correct for J2EE 1.4 version
> -----------------------------------------------------------------------
>
>                 Key: MECLIPSE-453
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-453
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse Europa 3.3.2, Maven 2.0.8
>            Reporter: M.-Leander Reimer
>         Attachments: EclipseWtpApplicationXMLWriter.java, JavaEE5.patch
>
>
> The generated Eclipse WTP application.xml has a hard coded header and does not respect the actual JEE version used, so for JEE5 the header should look like the following 
> <application xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/application_5.xsd" id="Application_ID" version="5">
> instead of 
> <application xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/application_1_4.xsd" id="Application_ID" version="1.4">
> The required, minimal changes are in the method createNewApplicationXml() in the class EclipseWtpApplicationXMLWriter.java 
> Unfortunately I could not compile and test the 2.5.1 source from SVN on my machine (the plugin unit tests failed), but I attached the changed file anyway.
> Best regards,
> Leander

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-453) Generated Eclipse WTP application.xml only correct for J2EE 1.4 version

Posted by "Carsten Mjartan (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Mjartan updated MECLIPSE-453:
-------------------------------------

    Attachment: JavaEE5.patch

Updated patch for 2.9-SNAPSHOT

> Generated Eclipse WTP application.xml only correct for J2EE 1.4 version
> -----------------------------------------------------------------------
>
>                 Key: MECLIPSE-453
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-453
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse Europa 3.3.2, Maven 2.0.8
>            Reporter: M.-Leander Reimer
>         Attachments: EclipseWtpApplicationXMLWriter.java, JavaEE5.patch
>
>
> The generated Eclipse WTP application.xml has a hard coded header and does not respect the actual JEE version used, so for JEE5 the header should look like the following 
> <application xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/application_5.xsd" id="Application_ID" version="5">
> instead of 
> <application xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/application_1_4.xsd" id="Application_ID" version="1.4">
> The required, minimal changes are in the method createNewApplicationXml() in the class EclipseWtpApplicationXMLWriter.java 
> Unfortunately I could not compile and test the 2.5.1 source from SVN on my machine (the plugin unit tests failed), but I attached the changed file anyway.
> Best regards,
> Leander

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MECLIPSE-453) Generated Eclipse WTP application.xml only correct for J2EE 1.4 version

Posted by "Anthony O. (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249389#action_249389 ] 

Anthony O. commented on MECLIPSE-453:
-------------------------------------

That bug still exists in Eclipse 3.5.2, is there a workaround ?

> Generated Eclipse WTP application.xml only correct for J2EE 1.4 version
> -----------------------------------------------------------------------
>
>                 Key: MECLIPSE-453
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-453
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse Europa 3.3.2, Maven 2.0.8
>            Reporter: M.-Leander Reimer
>         Attachments: EclipseWtpApplicationXMLWriter.java, JavaEE5.patch
>
>
> The generated Eclipse WTP application.xml has a hard coded header and does not respect the actual JEE version used, so for JEE5 the header should look like the following 
> <application xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/application_5.xsd" id="Application_ID" version="5">
> instead of 
> <application xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/application_1_4.xsd" id="Application_ID" version="1.4">
> The required, minimal changes are in the method createNewApplicationXml() in the class EclipseWtpApplicationXMLWriter.java 
> Unfortunately I could not compile and test the 2.5.1 source from SVN on my machine (the plugin unit tests failed), but I attached the changed file anyway.
> Best regards,
> Leander

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira