[jira] [Resolved] (SPARK-13583) Remove unused imports and add checkstyle rule

["Sean Owen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved SPARK-13583.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request 11438
[https://github.com/apache/spark/pull/11438]

> Remove unused imports and add checkstyle rule
> ---------------------------------------------
>
>                 Key: SPARK-13583
>                 URL: https://issues.apache.org/jira/browse/SPARK-13583
>             Project: Spark
>          Issue Type: Task
>          Components: Spark Core, Streaming
>            Reporter: Dongjoon Hyun
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> After SPARK-6990, `dev/lint-java` keeps Java code healthy and helps PR review by saving much time.
> This issue aims to enforce `UnusedImports` rule by adding a `UnusedImports` rule to `checkstyle.xml` and fixing all existing unused imports.
> {code:title=checkstyle.xml|borderStyle=solid}
> +        <module name="UnusedImports"/>
> {code}
> Unfortunately, `dev/lint-java` is not tested by Jenkins. ( https://github.com/apache/spark/blob/master/dev/run-tests.py#L546 )
> This will also help Spark contributors to check by themselves before submitting their PRs.
> According to the [~srowen]'s comments, this PR also includes the removal of unused imports in Scala code. It will be done by manually because of the following two reasons. 
>   * Scalastyle does not have `UnusedImport` rule yet.
>   * Scala 2.11.7 has a bug with `-Ywarn-unused-import` option.
>     (https://issues.scala-lang.org/browse/SI-9616)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org