You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/21 03:17:26 UTC

[GitHub] [flink] deadwind4 commented on a diff in pull request #19972: [FLINK-27399][Connector/Pulsar] Change initial consuming position setting logic for better handle the checkpoint.

deadwind4 commented on code in PR #19972:
URL: https://github.com/apache/flink/pull/19972#discussion_r902125914


##########
flink-python/pyflink/datastream/connectors/pulsar.py:
##########
@@ -138,10 +138,10 @@ def latest() -> 'StartCursor':
         return StartCursor(JStartCursor.latest())
 
     @staticmethod
-    def from_message_time(timestamp: int) -> 'StartCursor':
+    def from_publish_time(timestamp: int) -> 'StartCursor':

Review Comment:
   Should we like this to keep forward-compatibility?
   
   https://github.com/apache/flink/blob/314e276f6c6bff990e82515d6ce90fd6a7c9561d/flink-python/pyflink/datastream/connectors/pulsar.py#L192-L207



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org