[GitHub] [arrow] maartenbreddels commented on a change in pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

[GitBox <gi...@apache.org>]

maartenbreddels commented on a change in pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#discussion_r451389530



##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -183,6 +188,53 @@ struct UTF8Transform {
   }
 };
 
+template <typename StringType, typename Derived>
+struct BinaryToBoolean {

Review comment:
       Good that you ask, would you say my approach is more, or less readable? I prefer the CRTP pattern. But it needs some changes to suit your needs (it needs to use non-statics, since it needs to store the pattern/table). If you prefer my approach I can refactor your code when I start on `startswith` or the regex version of your kernel. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org