You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/20 10:24:55 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4865: metadata&schema lambda modify

kimmking opened a new pull request #4865: metadata&schema lambda modify
URL: https://github.com/apache/incubator-shardingsphere/pull/4865
 
 
   
   Changes proposed in this pull request:
   - metadata&schema lambda modify
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4865: metadata&schema lambda modify

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4865: metadata&schema lambda modify
URL: https://github.com/apache/incubator-shardingsphere/pull/4865#issuecomment-601639276
 
 
   ## Pull Request Test Coverage Report for [Build 2193](https://coveralls.io/builds/29497546)
   
   * **3** of **7**   **(42.86%)**  changed or added relevant lines in **2** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.006%**) to **58.721%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29497546/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L59) | 0 | 4 | 0.0%
   <!-- | **Total:** | **3** | **7** | **42.86%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29497546/badge)](https://coveralls.io/builds/29497546) |
   | :-- | --: |
   | Change from base [Build 1129](https://coveralls.io/builds/29494879): |  0.006% |
   | Covered Lines: | 11908 |
   | Relevant Lines: | 20279 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4865: metadata&schema lambda modify

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4865: metadata&schema lambda modify
URL: https://github.com/apache/incubator-shardingsphere/pull/4865#issuecomment-601639276
 
 
   ## Pull Request Test Coverage Report for [Build 10445](https://coveralls.io/builds/29498195)
   
   * **3** of **7**   **(42.86%)**  changed or added relevant lines in **2** files are covered.
   * **18** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.07%**) to **58.642%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29498195/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L59) | 0 | 4 | 0.0%
   <!-- | **Total:** | **3** | **7** | **42.86%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29498195/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29498195/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29498195/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
   <!-- | **Total:** | **18** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29498195/badge)](https://coveralls.io/builds/29498195) |
   | :-- | --: |
   | Change from base [Build 1129](https://coveralls.io/builds/29494879): |  -0.07% |
   | Covered Lines: | 11892 |
   | Relevant Lines: | 20279 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4865: metadata&schema lambda modify

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4865: metadata&schema lambda modify
URL: https://github.com/apache/incubator-shardingsphere/pull/4865
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4865: metadata&schema lambda modify

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4865: metadata&schema lambda modify
URL: https://github.com/apache/incubator-shardingsphere/pull/4865#issuecomment-601650158
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=h1) Report
   > Merging [#4865](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ce1ee6b617c94859923549c7967f7f166aca2e50&el=desc) will **decrease** coverage by `0.92%`.
   > The diff coverage is `42.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4865      +/-   ##
   ============================================
   - Coverage     56.03%   55.10%   -0.93%     
   + Complexity      449      436      -13     
   ============================================
     Files          1166     1136      -30     
     Lines         20863    20279     -584     
     Branches       3882     3743     -139     
   ============================================
   - Hits          11690    11175     -515     
   + Misses         8445     8399      -46     
   + Partials        728      705      -23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...here/shardingproxy/backend/schema/LogicSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ng/common/metadata/datasource/DataSourceMetas.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL21ldGFkYXRhL2RhdGFzb3VyY2UvRGF0YVNvdXJjZU1ldGFzLmphdmE=) | `86.66% <100.00%> (+4.05%)` | `0.00 <0.00> (ø)` | |
   | [...ql/binlog/codec/MySQLBinlogEventPacketDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL2NvZGVjL015U1FMQmlubG9nRXZlbnRQYWNrZXREZWNvZGVyLmphdmE=) | | | |
   | [...og/packet/binlog/FormatDescriptionEventPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL3BhY2tldC9iaW5sb2cvRm9ybWF0RGVzY3JpcHRpb25FdmVudFBhY2tldC5qYXZh) | | | |
   | [...scaling/mysql/binlog/packet/binlog/EventTypes.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL3BhY2tldC9iaW5sb2cvRXZlbnRUeXBlcy5qYXZh) | | | |
   | [...ysql/binlog/packet/binlog/TableMapEventPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL3BhY2tldC9iaW5sb2cvVGFibGVNYXBFdmVudFBhY2tldC5qYXZh) | | | |
   | [...ng/mysql/binlog/packet/binlog/RowsEventPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL3BhY2tldC9iaW5sb2cvUm93c0V2ZW50UGFja2V0LmphdmE=) | | | |
   | [...ng/mysql/binlog/codec/DateAndTimeValueDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL2NvZGVjL0RhdGVBbmRUaW1lVmFsdWVEZWNvZGVyLmphdmE=) | | | |
   | [...caling/mysql/binlog/codec/DecimalValueDecoder.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL2NvZGVjL0RlY2ltYWxWYWx1ZURlY29kZXIuamF2YQ==) | | | |
   | [.../mysql/binlog/packet/binlog/RotateEventPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL3BhY2tldC9iaW5sb2cvUm90YXRlRXZlbnRQYWNrZXQuamF2YQ==) | | | |
   | ... and [38 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=footer). Last update [ce1ee6b...a4315b9](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services