You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/12/02 00:26:13 UTC

[kudu-CR] Disable flaky KUDU-1097 tablet move test

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8720

to review the following change.


Change subject: Disable flaky KUDU-1097 tablet move test
......................................................................

Disable flaky KUDU-1097 tablet move test

This test is flaky because the leader may get marked with replace, which
is not currently reliably supported when KUDU-1097 is enabled.

Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/8720/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
Gerrit-Change-Number: 8720
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] Disable flaky KUDU-1097 tablet move test

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8720 )

Change subject: Disable flaky KUDU-1097 tablet move test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
Gerrit-Change-Number: 8720
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 02 Dec 2017 00:35:28 +0000
Gerrit-HasComments: No

[kudu-CR] Disable flaky KUDU-1097 tablet move test

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8720 )

Change subject: Disable flaky KUDU-1097 tablet move test
......................................................................


Patch Set 1: Verified+1

overriding unrelated flake


-- 
To view, visit http://gerrit.cloudera.org:8080/8720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
Gerrit-Change-Number: 8720
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 00:59:15 +0000
Gerrit-HasComments: No

[kudu-CR] Disable flaky KUDU-1097 tablet move test

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8720 )

Change subject: Disable flaky KUDU-1097 tablet move test
......................................................................

Disable flaky KUDU-1097 tablet move test

This test is flaky because the leader may get marked with replace, which
is not currently reliably supported when KUDU-1097 is enabled.

Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
Reviewed-on: http://gerrit.cloudera.org:8080/8720
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Mike Percy: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
Gerrit-Change-Number: 8720
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Disable flaky KUDU-1097 tablet move test

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.

Change subject: Disable flaky KUDU-1097 tablet move test
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/8720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I118accafd7da99c35beb5a4f4a9f164984f17baf
Gerrit-Change-Number: 8720
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>