[jira] Updated: (DERBY-4757) (Client) Implement UTF8 support on DRDA

["Tiago R. Espinha (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tiago R. Espinha updated DERBY-4757:
------------------------------------

    Attachment: DERBY-4757_p1.diff

I'm attaching a patch that lays the foundation for the UTF-8 support in the client. The patch may seem massive but all the changes are actually related. Here's an overview of what it does:

- Changes the method names for the CcsidManager abstract class so that they are clearer in terms of what they do (convertToJavaString, convertFromJavaString) similar to what's been done for the server.

Still on the CcsidManager changes, the patch refactors the code so that the new method names are used. It also introduces a new name to the CcsidManager that returns, for the given CcsidManager, the length of a String in bytes (which differs for the different managers).

- Creates the Utf8CcsidManager.java for the client and the respective Utf8CcsidManagerClientTest.java. I wasn't sure what to name this test since there is already a test for the server, so I decided to include "Client" in its name. If there is a preferred alternative, I can change it. I have also hooked this test into the suite.

- Changes NetAgent.java so that it no longer has a source and target CCSID managers. Also, similarly to the server, it now has an instance of each type of CCSID (EBCDIC and UTF-8) and a current CCSID which is the one currently in use.

In NetAgent.java, I've also set the CCSID managers to private and created a getter for the current manager to enforce encapsulation.

In sum, this patch does not yet enable UTF-8 support but puts everything in place so that the switch mechanism can be implemented.

I will now be running regressions.

> (Client) Implement UTF8 support on DRDA
> ---------------------------------------
>
>                 Key: DERBY-4757
>                 URL: https://issues.apache.org/jira/browse/DERBY-4757
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Client
>    Affects Versions: 10.7.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4757_p1.diff
>
>
> This issue is DERBY-4746's counterpart for the client changes required to implement UTF8 support in DRDA.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.