[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3207: Fix #3203 usage server broken in 4.12.0.0

[GitBox <gi...@apache.org>]

GabrielBrascher opened a new pull request #3207: Fix #3203 usage server broken in 4.12.0.0 
URL: https://github.com/apache/cloudstack/pull/3207
 
 
   Fixes issue #3203.
   
   Due to the migration to systemd the java application for the cloudstack-usage.service the configuration `-Dpid=$$ ` did not returned the pid value but the string '$$'; thus, the _pid variable received '$$', causing a silenced exception.
   
   This PR adds the file `/etc/cloudstack/usage/cloudstack-usage.service.pid` that has the process pid. The file is configured after the ExecStart, by running the `systemctl show` command configured as:
   
   `ExecStartPost=/bin/sh -c "systemctl show -p MainPID cloudstack-usage.service 2>/dev/null | cut -d= -f2 > /etc/cloudstack/usage/cloudstack-usage.service.pid"`
   
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   CloudStack usage service run as expected after inseting the code from this PR.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services