[SOURCE] Issue #TRQS113 - ncorrect logic for reporting non existant column

[David Wynter <da...@roamware.com>]

You can view the issue detail at the following URL:
<http://scarab.werken.com/scarab/issues/id/TRQS113>

Type :        Defect
Issue Id :    TRQS113
Reported by: David Wynter
             roamdave - (david@roamware.com)

Details:

Summary: ncorrect logic for reporting non existant column
Description: You can see here in 
org.apache.torque.engine.database.model.Database.doFinalInitialization(Database.java:444):

441                     if (local == null)
442                     {
443                         System.out.println("ERROR!! Attempt to define foreign"
444                                 + " key with nonexistent column, "
445                                 + local.getName() + ", in table, "
446                                 + currTable.getName() + "!");
447                     }

clearly if local == null local.getName() will fail.

Should be

441                     if (local != null)
442                     {
443                         System.out.println("ERROR!! Attempt to define foreign"
444                                 + " key with nonexistent column, "
445                                 + local.getName() + ", in table, "
446                                 + currTable.getName() + "!");
447                     } else {
448                         System.out.println("ERROR!! Attempt to define foreign"
449                                 + " key with nonexistent column, name unknown"
450                                ", in table, " + currTable.getName() + "!");
451                     }

or similar

Status: New
Resolution: Later
Database: MySQL
Operating system: Windows
Priority: Undecided