[GitHub] [helix] alirezazamani commented on a change in pull request #1637: Skip cancellation for partition reset pending message

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1637:
URL: https://github.com/apache/helix/pull/1637#discussion_r570627836



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
##########
@@ -271,6 +271,23 @@ private void generateMessage(final Resource resource, final BaseControllerDataPr
     } // end of for-each-partition
   }
 
+  private boolean shouldCreateSTCancellation(Message pendingMessage, String currentState,

Review comment:
       One question: As participants and controller are async with each other, what would happen when the participant is processing the previous message (pending message is still there) and once the cancellation message is being sent, then ST has been executed by the participant? This would potentially happen when pipeline processing time gets extended.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org