You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2017/01/10 11:52:12 UTC
[GitHub] brooklyn-server pull request #510: Fix logging of creation string in Jclouds...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/510
Fix logging of creation string in JcloudsLocation
Use `getCreationString` rather than `setup.getDescription` throughout `JcloudsLocation`.
Fixes the annoying nulls in log messages when locations are provisioned:
```
2017-01-10 10:54:17,954 INFO Creating VM null in JcloudsLocation[...]
2017-01-10 11:00:34,114 ERROR Failed to start VM for null;
```
etc.
See 8405d8774a0380a99b9dd1fbd2daf7fc15265cb8 for the introduction of `getCreationString`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server fix/jclouds-description
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/510.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #510
----
commit 954fbd580260640816cdd0f4cf86f61185a5f90b
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2017-01-10T11:33:07Z
Fix logging of creation string in JcloudsLocation
Commit 8405d8774a0380a99b9dd1fbd2daf7fc15265cb8 switched from setting
a description on the config bag to providing a `getCreationString`
method but did not use it throughout the class, meaning several
statements logged `null`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #510: Fix logging of creation string in Jclouds...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/510#discussion_r95351893
--- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java ---
@@ -651,7 +651,7 @@ protected MachineLocation obtainOnce(ConfigBag setup) throws NoMachinesAvailable
Stopwatch provisioningStopwatch = Stopwatch.createStarted();
try {
- LOG.info("Creating VM "+setup.getDescription()+" in "+this);
+ LOG.info("Creating VM "+getCreationString(setup)+" in "+this);
--- End diff --
[minor / ignore] I would change this to `LOG.info("Creating VM {} in {}", getCreationString(setup), this);`
probably applies elsewhere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #510: Fix logging of creation string in Jclouds...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #510: Fix logging of creation string in JcloudsLocatio...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/510
LGTM - thanks @sjcorbett; merging.
It looks like we'll no longer log the `setup.getDescription()` when it's non-null, but that's fine. It's pretty much always null in the logs I've seen, I think, and the getCreationString looks like it'll be nicer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---