You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "julien-vaz (via GitHub)" <gi...@apache.org> on 2025/02/18 14:12:29 UTC
[PR] Add logs for storage pools reordering [cloudstack]
julien-vaz opened a new pull request, #10419:
URL: https://github.com/apache/cloudstack/pull/10419
### Description
Since the storage pool reordering process was lacking logs for troubleshooting, some debug level log messages were added and trace level log messages were changed to the debug level. Also, the log messages were rewritten according to the new Log4j2 syntax.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
1. A volume was created;
2. Its disk offering was changed;
3. It was verified that the log messages were properly being displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2701490385
Alright, I've just changed the level of logs on reordering methods, @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2704671219
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4226350214
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2943448806
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2887198393
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3241830994
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "rosi-shapeblue (via GitHub)" <gi...@apache.org>.
rosi-shapeblue commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3194289428
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3068059558
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on code in PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#discussion_r1976480634
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -248,15 +237,16 @@ List<StoragePool> reorderStoragePoolsBasedOnAlgorithm(List<StoragePool> pools, D
void reorderRandomPools(List<StoragePool> pools) {
StorageUtil.traceLogStoragePools(pools, logger, "pools to choose from: ");
if (logger.isTraceEnabled()) {
- logger.trace(String.format("Shuffle this so that we don't check the pools in the same order. Algorithm == '%s' (or no account?)", allocationAlgorithm));
+ logger.trace("Shuffle this so that we don't check the pools in the same order. Algorithm == '[{}]' (or no account?)", allocationAlgorithm);
Review Comment:
```suggestion
logger.trace("Shuffling the list of storage pools, since the algorithm is '[{}]' or no account has been specified", allocationAlgorithm);
```
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -270,22 +260,24 @@ private List<StoragePool> reorderPoolsByDiskProvisioningType(List<StoragePool> p
reorderedPools.add(preferredIndex++, pool);
}
}
+ logger.debug("Reordered list of pools by disk provisioning type [{}]: [{}]", diskProfile.getProvisioningType(), pools);
return reorderedPools;
} else {
+ logger.debug("Reordering pools by disk provisioning type wasn't necessary.");
Review Comment:
We could specify the reason for the reordering of pools not being necessary here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2996712052
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3067916954
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2665834876
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3236817199
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4241977182
@sureshanaparti , I think this is ready for merge. Only logging and integration tests pass in the lab, GHA don’t all pass, but that seems like a more generic issue than this PR. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3891199701
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3890837264
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2940816545
> @julien-vaz could you fix the conflicts?
Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2996708070
I've just build the packages locally, so I'm triggering the Blue Orangutan again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4229233059
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3240026583
<b>[SF] Trillian test result (tid-14157)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 733 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t14157-kvm-ol8.zip
Smoke tests completed. 0 look OK, 0 have errors, 146 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3737426476
@julien-vaz Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3032063942
<b>[SF] Trillian test result (tid-13665)</b>
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 61144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t13665-kvm-ubuntu22.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2955725399
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3240099768
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2704508081
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3236816898
rebuilding as 4.22 feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4230456502
<b>[SF] Trillian test result (tid-15857)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49952 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t15857-kvm-ol8.zip
Smoke tests completed. 147 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_ping_in_ssvm_success | `Failure` | 15.39 | test_diagnostics.py
test_05_ping_in_cpvm_success | `Failure` | 15.43 | test_diagnostics.py
test_04_extract_Iso | `Failure` | 1.07 | test_iso.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#discussion_r2182851158
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -374,11 +368,11 @@ protected boolean filter(ExcludeList avoid, StoragePool pool, DiskProfile dskCh,
storageMgr.isStoragePoolCompliantWithStoragePolicy(dskCh.getDiskOfferingId(), pool) :
storageMgr.isStoragePoolCompliantWithStoragePolicy(requestVolumeDiskProfilePairs, pool);
if (!isStoragePoolStoragePolicyCompliance) {
- logger.debug(String.format("Skipping allocation of pool [%s] to volume [%s] because this pool is not compliant with the storage policy required by the volume.", pool, volume));
+ logger.debug("Skipping allocation of pool [{}] to volume [{}] because this pool is not compliant with the storage policy required by the volume.", pool, volume);
return false;
}
} catch (StorageUnavailableException e) {
- logger.warn(String.format("Could not verify storage policy complaince against storage pool %s due to exception %s", pool.getUuid(), e.getMessage()));
+ logger.warn("Could not verify storage policy complaince against storage pool [{}] due to exception [{}]", pool.getUuid(), e.getMessage());
Review Comment:
```suggestion
logger.warn("Could not verify storage policy compliance against storage pool [{}] due to exception [{}]", pool.getUuid(), e.getMessage());
```
sorry for the late remark,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3028694217
> > I've just built the packages locally, so I'm triggering the Blue Orangutan again.
>
> why do you think this is needed @julien-vaz ?
Because the debian build has failed previously
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2932281620
@julien-vaz could you fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on code in PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#discussion_r1983496413
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -194,16 +194,11 @@ protected List<StoragePool> reorderPoolsByNumberOfVolumes(DeploymentPlan plan, L
@Override
public List<StoragePool> reorderPools(List<StoragePool> pools, VirtualMachineProfile vmProfile, DeploymentPlan plan, DiskProfile dskCh) {
- if (logger.isTraceEnabled()) {
- logger.trace("reordering pools");
- }
if (pools == null) {
- logger.trace("There are no pools to reorder; returning null.");
+ logger.info("There are no pools to reorder; returning null.");
Review Comment:
I agree with you. Thanks for pointing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3803951475
@julien-vaz can you please resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "erikbocks (via GitHub)" <gi...@apache.org>.
erikbocks commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3890487781
Hello, @borisstoyanov and @rajujith
The conflicts were solved, can we move forward with this PR? I think it is ready to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4229231283
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2955731451
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3067914648
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "julien-vaz (via GitHub)" <gi...@apache.org>.
julien-vaz commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2996708836
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3028965949
@DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#discussion_r2726858773
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -282,22 +270,28 @@ private List<StoragePool> reorderPoolsByDiskProvisioningType(List<StoragePool> p
reorderedPools.add(preferredIndex++, pool);
}
}
+ logger.debug("Reordered list of pools by disk provisioning type [{}]: [{}]", diskProfile.getProvisioningType(), pools);
Review Comment:
This debug statement logs the original `pools` list even though the method has just built a `reorderedPools` list and is about to return it, which makes the message misleading when troubleshooting reordering by disk provisioning type. Consider logging the reordered list instead so the log output reflects the actual ordering that will be used.
```suggestion
logger.debug("Reordered list of pools by disk provisioning type [{}]: [{}]", diskProfile.getProvisioningType(), reorderedPools);
```
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -206,16 +206,11 @@ protected List<StoragePool> reorderPoolsByNumberOfVolumes(DeploymentPlan plan, L
@Override
public List<StoragePool> reorderPools(List<StoragePool> pools, VirtualMachineProfile vmProfile, DeploymentPlan plan, DiskProfile dskCh) {
- if (logger.isTraceEnabled()) {
- logger.trace("reordering pools");
- }
if (pools == null) {
- logger.trace("There are no pools to reorder; returning null.");
+ logger.info("There are no pools to reorder.");
return null;
}
- if (logger.isTraceEnabled()) {
- logger.trace(String.format("reordering %d pools", pools.size()));
- }
+ logger.info("Reordering [{}] pools", pools.size());
Review Comment:
These log statements (and similar ones added below) have been raised to INFO level, which means every pool reordering attempt will now be emitted at INFO instead of DEBUG/TRACE and can significantly increase log volume in busy environments. This also goes beyond the PR description (which mentioned adding DEBUG logs and promoting TRACE to DEBUG), so please confirm that INFO is the intended level for these high-frequency paths or consider keeping them at DEBUG while still adopting the new Log4j2 placeholder syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4239741103
<b>[SF] Trillian test result (tid-15860)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49500 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t15860-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4242067697
> @sureshanaparti , I think this is ready for merge. Only logging and integration tests pass in the lab, GHA don’t all pass, but that seems like a more generic issue than this PR. What do you think?
agree @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2704512166
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3194325501
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2943887500
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3240049793
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3236819007
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3237105924
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3890843921
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3304513904
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3028964641
> > why do you think this is needed @julien-vaz ?
>
> Because the debian build has failed previously
ok, nothing related to your changes but now you asked for it ;)
@blueorangutan test ubuntu22 kvm-ubuntu22 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3032361805
sorry @julien-vaz , I did some greps on the logs and it all looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#discussion_r1983109264
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -194,16 +194,11 @@ protected List<StoragePool> reorderPoolsByNumberOfVolumes(DeploymentPlan plan, L
@Override
public List<StoragePool> reorderPools(List<StoragePool> pools, VirtualMachineProfile vmProfile, DeploymentPlan plan, DiskProfile dskCh) {
- if (logger.isTraceEnabled()) {
- logger.trace("reordering pools");
- }
if (pools == null) {
- logger.trace("There are no pools to reorder; returning null.");
+ logger.info("There are no pools to reorder; returning null.");
Review Comment:
```suggestion
logger.info("There are no pools to reorder.");
```
I don't think the return is worth logging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4226636340
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3239944906
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3240048584
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3194290230
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3381147144
@julien-vaz can you please fix the conflicts, lets try to put this in 4.22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "erikbocks (via GitHub)" <gi...@apache.org>.
erikbocks closed pull request #10419: Add logs for storage pools reordering
URL: https://github.com/apache/cloudstack/pull/10419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3891035074
@julien-vaz @erikbocks can you check the build errors.
```
Error: testregisterBackupForVMwithOutSsid(org.apache.backup.networker.NetworkerClientTest) Time elapsed: 0.387 s <<< FAILURE!
...
Error: NetworkerClientTest.testregisterBackupForVMwithOutSsid:637 No requests exactly matched. Most similar request was: expected:<
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2666012095
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10419?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.00%. Comparing base [(`22c7192`)](https://app.codecov.io/gh/apache/cloudstack/commit/22c71928dd28dc3217e59c9d4d7dacc56621a02f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fce33d9`)](https://app.codecov.io/gh/apache/cloudstack/commit/fce33d91c6594e3571f8b59b668526ab7e431ef9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 36 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (22c7192) and HEAD (fce33d9). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (22c7192) | HEAD (fce33d9) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #10419 +/- ##
=============================================
- Coverage 16.02% 4.00% -12.03%
=============================================
Files 5658 396 -5262
Lines 496312 32519 -463793
Branches 60109 5759 -54350
=============================================
- Hits 79538 1302 -78236
+ Misses 407925 31067 -376858
+ Partials 8849 150 -8699
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10419/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10419/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10419/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10419?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2943447229
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "erikbocks (via GitHub)" <gi...@apache.org>.
erikbocks commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3891675764
@sureshanaparti I runned the tests locally and no problem was found. I will trigger the build again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2996969623
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2996778678
> I've just built the packages locally, so I'm triggering the Blue Orangutan again.
why do you think this is needed @julien-vaz ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2957769146
<b>[SF] Trillian test result (tid-13481)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t13481-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2963668054
@sureshanaparti , do you think we need anymore testing on this? (/me not convinced)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3241827906
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3239943992
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-3243584453
<b>[SF] Trillian test result (tid-14164)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t14164-kvm-ol8.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1452.41 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10419:
URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-4226360980
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org