You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by re...@apache.org on 2026/02/23 15:14:30 UTC

(cloudberry) 01/01: Remove bogus loop in single-iteration code

This is an automated email from the ASF dual-hosted git repository.

reshke pushed a commit to branch reshke-patch-2
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit 749cb307afe3e9c2ea0171ecb52478e138e862cf
Author: reshke <re...@double.cloud>
AuthorDate: Mon Feb 23 20:14:23 2026 +0500

    Remove bogus loop in single-iteration code
    
    While casually reading SonarQube output, I spotted this oddly-factioned code.
---
 src/backend/access/appendonly/appendonlyam.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/access/appendonly/appendonlyam.c b/src/backend/access/appendonly/appendonlyam.c
index b5f6a17a597..defa5ccc80e 100755
--- a/src/backend/access/appendonly/appendonlyam.c
+++ b/src/backend/access/appendonly/appendonlyam.c
@@ -1983,7 +1983,7 @@ appendonly_endscan(TableScanDesc scan)
 static pg_attribute_hot_inline bool
 appendonly_getnextslot_noqual(AppendOnlyScanDesc aoscan, ScanDirection direction, TupleTableSlot *slot)
 {
-	while (appendonlygettup(aoscan, direction, aoscan->rs_base.rs_nkeys, aoscan->aos_key, slot))
+	if (appendonlygettup(aoscan, direction, aoscan->rs_base.rs_nkeys, aoscan->aos_key, slot))
 	{
 		pgstat_count_heap_getnext(aoscan->aos_rd);
 		return true;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org