You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/17 03:45:34 UTC

[GitHub] [apisix] zaunist opened a new pull request #6637: backport: update luarocks version to 3.8.0

zaunist opened a new pull request #6637:
URL: https://github.com/apache/apisix/pull/6637


   ### Description
   
   luarocks 3.4.0 is out of date, we need to upgrade to 3.8.0
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] nic-chen commented on a change in pull request #6637: backport: update luarocks version to 3.8.0

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #6637:
URL: https://github.com/apache/apisix/pull/6637#discussion_r828753170



##########
File path: utils/linux-install-luarocks.sh
##########
@@ -38,10 +40,11 @@ fi
 ./configure $WITH_LUA_OPT \
     > build.log 2>&1 || (cat build.log && exit 1)
 
+rm -rf luarocks-"$LUAROCKS_VER"

Review comment:
       delete before `make build` and `make install`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #6637: backport: update luarocks version to 3.8.0

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6637:
URL: https://github.com/apache/apisix/pull/6637


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] bzp2010 commented on a change in pull request #6637: backport: update luarocks version to 3.8.0

Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #6637:
URL: https://github.com/apache/apisix/pull/6637#discussion_r828743548



##########
File path: utils/linux-install-luarocks.sh
##########
@@ -41,7 +43,6 @@ fi
 make build > build.log 2>&1 || (cat build.log && exit 1)
 sudo make install > build.log 2>&1 || (cat build.log && exit 1)
 cd .. || exit
-rm -rf luarocks-3.4.0

Review comment:
       Why was this cleanup removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] zaunist commented on a change in pull request #6637: backport: update luarocks version to 3.8.0

Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #6637:
URL: https://github.com/apache/apisix/pull/6637#discussion_r828744904



##########
File path: utils/linux-install-luarocks.sh
##########
@@ -41,7 +43,6 @@ fi
 make build > build.log 2>&1 || (cat build.log && exit 1)
 sudo make install > build.log 2>&1 || (cat build.log && exit 1)
 cd .. || exit
-rm -rf luarocks-3.4.0

Review comment:
       My mistake, I will add the cleanup code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] zaunist commented on pull request #6637: backport: update luarocks version to 3.8.0

Posted by GitBox <gi...@apache.org>.
zaunist commented on pull request #6637:
URL: https://github.com/apache/apisix/pull/6637#issuecomment-1070310946


   @shuaijinchao @tzssangglass Please take a look, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] zaunist commented on a change in pull request #6637: backport: update luarocks version to 3.8.0

Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #6637:
URL: https://github.com/apache/apisix/pull/6637#discussion_r828758960



##########
File path: utils/linux-install-luarocks.sh
##########
@@ -38,10 +40,11 @@ fi
 ./configure $WITH_LUA_OPT \
     > build.log 2>&1 || (cat build.log && exit 1)
 
+rm -rf luarocks-"$LUAROCKS_VER"

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org