You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "lifeSo (via GitHub)" <gi...@apache.org> on 2023/12/25 02:23:13 UTC
[PR] [851] Improvement: Add a similar util method like ThreadUtils.parmap in the Spark [incubator-uniffle]
lifeSo opened a new pull request, #1396:
URL: https://github.com/apache/incubator-uniffle/pull/1396
### What changes were proposed in this pull request?
Add a similar util method like ThreadUtils.parmap in the Spark
### Why are the changes needed?
Fix: https://github.com/apache/incubator-uniffle/issues/851
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1396:
URL: https://github.com/apache/incubator-uniffle/pull/1396#issuecomment-1869875772
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1396:
URL: https://github.com/apache/incubator-uniffle/pull/1396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark —— test [incubator-uniffle]
Posted by "lifeSo (via GitHub)" <gi...@apache.org>.
lifeSo commented on PR #1396:
URL: https://github.com/apache/incubator-uniffle/pull/1396#issuecomment-1868672232
now for test, I will corret it later and inform Dalao.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [851] improvement: Add a similar util method like ThreadUtils.parmap in the Spark —— test [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1396:
URL: https://github.com/apache/incubator-uniffle/pull/1396#issuecomment-1868675683
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1396?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `18 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`ecbf2e7`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/ecbf2e79423505dd44bf54c612572c5c9da71175?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.22% compared to head [(`2e5c1c2`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1396?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.41%.
> Report is 15 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...va/org/apache/uniffle/common/util/ThreadUtils.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi91dGlsL1RocmVhZFV0aWxzLmphdmE=) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1396 +/- ##
============================================
+ Coverage 53.22% 53.41% +0.18%
+ Complexity 2715 2191 -524
============================================
Files 418 342 -76
Lines 23932 15439 -8493
Branches 2043 1428 -615
============================================
- Hits 12738 8246 -4492
+ Misses 10408 6729 -3679
+ Partials 786 464 -322
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1396?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org