[GitHub] [curator] cammckenzie commented on a change in pull request #391: CURATOR-599 Configurable ZookeeperFactory by ZKClientConfig

[GitBox <gi...@apache.org>]

cammckenzie commented on a change in pull request #391:
URL: https://github.com/apache/curator/pull/391#discussion_r666537811



##########
File path: curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java
##########
@@ -1070,10 +1077,28 @@ public void testCreateModes() throws Exception
 
             stat = client.checkExists().forPath(realPath);
             assertNull(stat);
+            

Review comment:
       Break this off into a new unit test. It's got nothing to do with testing create modes.

##########
File path: curator-client/src/main/java/org/apache/curator/utils/ConfigurableZookeeperFactory.java
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.curator.utils;
+
+import org.apache.zookeeper.Watcher;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.admin.ZooKeeperAdmin;
+import org.apache.zookeeper.client.ZKClientConfig;
+
+/**
+ * Configurable ZookeeperFactory, by using org.apache.zookeeper.client.ZKClientConfig.
+ * 
+ * @author Liran Mendelovich

Review comment:
       We don't use @Author annotations (not sure why exactly, just history).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org