You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/07 14:45:48 UTC
[GitHub] [superset] cccs-RyanS opened a new issue, #19592: Adhoc filter popover simple tab on explore view does not render subject multi select if no suggestions are present
cccs-RyanS opened a new issue, #19592:
URL: https://github.com/apache/superset/issues/19592
In the explore view for a dataset there are a set of conditions which causes the the subject select to not render in the adhoc filter pop over control (AdhocFilterEditPopoverSimpleTabContent) . These condition are met when a column is selected and an operator belonging to the MULTI_OPERATORS list has also been selected and no suggestions have been populated.
I believe this to be caused by this line [here](https://github.com/apache/superset/blob/6d5771af346e1ae821b1ac0598751508265481a6/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx#L411) this seems to cause the behaviour that if you have a MULTI_OPERATOR and no suggestions the select will not render. The intention seems to be to delay rendering until suggestions are loaded, however there are cases where the suggestions will never load in some of our datasets.
If this is not intended behaviour I would also be more than happy to take a look and attempt a fix.
#### How to reproduce the bug
The bug is data source dependent but here are some steps to create a simple fake dataset that this bug will appear in
1. SQL Lab and input a query such as `select 1 as col1, 2 as col2, 3 as col3`
2. Save this query as a virtual dataset by clicking the explore button
3. Open the dataset in the explore view
4. click on filters to open the popover
5. select any col (col1, col2, col3) and select the IN operator
6. The multislect for the subject will not render
### Expected results
The multi select would render even if there are no suggestions loaded.
### Actual results
The subject multi select does not render.
#### Screenshots
### Environment
- browser: Firefox
- superset version: superset master branch and 1.5.0rc1
- python version: python 3.8.10
- node.js version: v16.13.0
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have not reproduced the issue with at least the latest released version of superset. however I have reproduced it for 1.5.0rc1
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed issue #19592: Adhoc filter popover simple tab on explore view does not render subject multi select if no suggestions are present
Posted by GitBox <gi...@apache.org>.
villebro closed issue #19592: Adhoc filter popover simple tab on explore view does not render subject multi select if no suggestions are present
URL: https://github.com/apache/superset/issues/19592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #19592: Adhoc filter popover simple tab on explore view does not render subject multi select if no suggestions are present
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #19592:
URL: https://github.com/apache/superset/issues/19592#issuecomment-1092629595
Thanks for reporting - I was able to reproduce, working on a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org