[GitHub] [arrow] pitrou commented on a change in pull request #9105: ARROW-11009: [C++] Allow changing default memory pool with an environment variable

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #9105:
URL: https://github.com/apache/arrow/pull/9105#discussion_r552053668



##########
File path: cpp/src/arrow/dataset/filter.cc
##########
@@ -704,28 +704,38 @@ using arrow::internal::JoinStrings;
 
 std::string AndExpression::ToString() const {
   return JoinStrings(
-      {"(", left_operand_->ToString(), " and ", right_operand_->ToString(), ")"}, "");
+      std::vector<util::string_view>{"(", left_operand_->ToString(), " and ",
+                                     right_operand_->ToString(), ")"},
+      "");

Review comment:
       @bkietz Do tell if this is too verbose for your taste (to be honest, I'm not sure why `JoinStrings` is used for simple concatenation here).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org